Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: services/device/device_service.cc

Issue 2734943003: Device Service: Decouple Wake Lock from //content (Closed)
Patch Set: Response to reviews Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/device/device_service.cc
diff --git a/services/device/device_service.cc b/services/device/device_service.cc
index f9bd085c75ac674dbeb17aecd383a8b1cc2510ea..e8e70af9a8be8c7926ccf6f75af8854de528d5a3 100644
--- a/services/device/device_service.cc
+++ b/services/device/device_service.cc
@@ -4,16 +4,20 @@
#include "services/device/device_service.h"
+#include <utility>
+
#include "base/bind.h"
#include "base/memory/ptr_util.h"
#include "base/memory/weak_ptr.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
+#include "device/wake_lock/wake_lock_context_provider.h"
#include "services/device/fingerprint/fingerprint.h"
#include "services/device/power_monitor/power_monitor_message_broadcaster.h"
#include "services/device/time_zone_monitor/time_zone_monitor.h"
#include "services/service_manager/public/cpp/connection.h"
#include "services/service_manager/public/cpp/interface_registry.h"
+#include "ui/gfx/native_widget_types.h"
#if defined(OS_ANDROID)
#include "services/device/android/register_jni.h"
@@ -22,25 +26,44 @@
namespace device {
+#if defined(OS_ANDROID)
std::unique_ptr<service_manager::Service> CreateDeviceService(
scoped_refptr<base::SingleThreadTaskRunner> file_task_runner,
- scoped_refptr<base::SingleThreadTaskRunner> io_task_runner) {
-#if defined(OS_ANDROID)
+ scoped_refptr<base::SingleThreadTaskRunner> io_task_runner,
+ const WakeLockContextCallback& wake_lock_context_callback) {
if (!EnsureJniRegistered()) {
DLOG(ERROR) << "Failed to register JNI for Device Service";
return nullptr;
}
-#endif
return base::MakeUnique<DeviceService>(std::move(file_task_runner),
+ std::move(io_task_runner),
+ wake_lock_context_callback);
+}
+#else
+std::unique_ptr<service_manager::Service> CreateDeviceService(
+ scoped_refptr<base::SingleThreadTaskRunner> file_task_runner,
+ scoped_refptr<base::SingleThreadTaskRunner> io_task_runner) {
+ return base::MakeUnique<DeviceService>(std::move(file_task_runner),
std::move(io_task_runner));
}
+#endif
+#if defined(OS_ANDROID)
+DeviceService::DeviceService(
+ scoped_refptr<base::SingleThreadTaskRunner> file_task_runner,
+ scoped_refptr<base::SingleThreadTaskRunner> io_task_runner,
+ const WakeLockContextCallback& wake_lock_context_callback)
+ : file_task_runner_(std::move(file_task_runner)),
+ io_task_runner_(std::move(io_task_runner)),
+ wake_lock_context_callback_(wake_lock_context_callback) {}
+#else
DeviceService::DeviceService(
scoped_refptr<base::SingleThreadTaskRunner> file_task_runner,
scoped_refptr<base::SingleThreadTaskRunner> io_task_runner)
: file_task_runner_(std::move(file_task_runner)),
io_task_runner_(std::move(io_task_runner)) {}
+#endif
DeviceService::~DeviceService() {}
@@ -52,6 +75,7 @@ bool DeviceService::OnConnect(const service_manager::ServiceInfo& remote_info,
registry->AddInterface<mojom::PowerMonitor>(this);
registry->AddInterface<mojom::ScreenOrientationListener>(this);
registry->AddInterface<mojom::TimeZoneMonitor>(this);
+ registry->AddInterface<mojom::WakeLockContextProvider>(this);
return true;
}
@@ -88,4 +112,10 @@ void DeviceService::Create(const service_manager::Identity& remote_identity,
time_zone_monitor_->Bind(std::move(request));
}
+void DeviceService::Create(const service_manager::Identity& remote_identity,
+ mojom::WakeLockContextProviderRequest request) {
+ WakeLockContextProvider::Create(std::move(request), file_task_runner_,
+ wake_lock_context_callback_);
+}
+
} // namespace device

Powered by Google App Engine
This is Rietveld 408576698