Device Service: Decouple Wake Lock from //content

device/wake_lock/wake_lock_context_provider.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "device/wake_lock/wake_lock_context_provider.h"
+
+#include "mojo/public/cpp/bindings/strong_binding.h"
+
+namespace device {
+
+// static
+void WakeLockContextProvider::Create(
+    mojom::WakeLockContextProviderRequest request,
+    scoped_refptr<base::SingleThreadTaskRunner> file_task_runner,
+    WakeLockContextCallback native_view_getter) {
+  mojo::MakeStrongBinding(base::MakeUnique<WakeLockContextProvider>(
+                              file_task_runner, native_view_getter),

[dcheng, 2017/03/17 06:55:26]

Nit: std::move (and #include <utility>)

[blundell, 2017/03/17 12:28:22]

Done.

+                          std::move(request));
+}
+
+WakeLockContextProvider::WakeLockContextProvider(
+    scoped_refptr<base::SingleThreadTaskRunner> file_task_runner,
+    WakeLockContextCallback native_view_getter)
+    : file_task_runner_(file_task_runner),

[dcheng, 2017/03/17 06:55:26]

Nit: std::move

[blundell, 2017/03/17 12:28:22]

Done.

+      native_view_getter_(native_view_getter) {}
+
+WakeLockContextProvider::~WakeLockContextProvider() {}
+
+void WakeLockContextProvider::GetContext(
+    int context_id,
+    mojo::InterfaceRequest<mojom::WakeLockContext> request) {
+  new WakeLockServiceContext(std::move(request), context_id, file_task_runner_,

[dcheng, 2017/03/17 06:55:26]

May be worth a comment here (or in the class header documentation) to briefly
explain the lifetime model of this object. For example, it seems like if
GetWakeLock is never called, this object will leak.

[blundell, 2017/03/17 12:28:21]

Done. (If GetWakeLock is never called, this object will die when the other side
drops its connection.)

+                             native_view_getter_);
+}
+
+}  // namespace device