device/wake_lock/public/interfaces/README.mojom - Issue 2734943003: Device Service: Decouple Wake Lock from //content

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: device/wake_lock/public/interfaces/README.mojom

Issue 2734943003: Device Service: Decouple Wake Lock from //content (Closed)

Patch Set: Response to review + rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/wake_lock/wake_lock_context_host.cc ('K') | « device/wake_lock/public/interfaces/BUILD.gn ('k') | device/wake_lock/public/interfaces/wake_lock_context.mojom » ('j') | device/wake_lock/wake_lock_context_provider.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 Provides the ability to block the device / display from sleeping.
	Ken Rockot(use gerrit already) 2017/03/16 17:48:40 README.mojom? README.mojom? dcheng 2017/03/17 06:55:26 Nit: should this be README.md? Nit: should this be README.md? blundell 2017/03/17 12:28:21 Who is README.mojom? My name is README.md. Show quoted text On 2017/03/17 06:55:26, dcheng wrote: > Nit: should this be README.md? Who is README.mojom? My name is README.md. blundell 2017/03/17 12:28:21 Who is README.mojom? My name is README.md. Show quoted text On 2017/03/16 17:48:40, Ken Rockot wrote: > README.mojom? Who is README.mojom? My name is README.md.
	2

	3 On Android, the implementation is inherently coupled to the NativeView

	4 associated with the context of the requestor due to system APIs. To handle

	5 this coupling, the Wake Lock usage model on Android is as follows:

	6

	7 (1) The embedder passes in a callback at Device Service construction that

	8 enables the Wake Lock implementation to map (embedder-specific) context IDs to

	9 NativeViews.

	10 (2) For a given embedder-specific context, a trusted client

	11 connects to the WakeLockContextProvider interface and gets a

	12 WakeLockContext instance that is associated with that context.

	13 (3) That trusted client then forwards requests to bind wake locks from

	14 untrusted clients that are made within that context, with the Wake Lock

	15 implementation using the callback from (1) as necessary to obtain the

	16 NativeView associated with that context.

	17

	18 On other platforms, the usage model is similar but the callback is not

	19 necessary/employed.

OLD	NEW