Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: ash/accelerators/accelerator_filter_unittest.cc

Issue 2734933004: ash: Use SessionController instead of SessionStateDelegate (Closed)
Patch Set: rebase to get WorkspaceLayoutManagerSoloTest change Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/accelerators/accelerator_filter_unittest.cc
diff --git a/ash/accelerators/accelerator_filter_unittest.cc b/ash/accelerators/accelerator_filter_unittest.cc
index bfa1c34ed2fb01da582df4df017e3a19d17e592f..d53f393bc204644fda8853ee62d776e0399668d7 100644
--- a/ash/accelerators/accelerator_filter_unittest.cc
+++ b/ash/accelerators/accelerator_filter_unittest.cc
@@ -8,7 +8,7 @@
#include "ash/accelerators/accelerator_delegate.h"
#include "ash/common/accelerators/accelerator_controller.h"
-#include "ash/common/test/test_session_state_delegate.h"
+#include "ash/common/session/session_controller.h"
#include "ash/common/wm/window_state.h"
#include "ash/common/wm_shell.h"
#include "ash/public/cpp/shell_window_ids.h"
@@ -149,27 +149,29 @@ TEST_F(AcceleratorFilterTest, CanConsumeSystemKeys) {
}
TEST_F(AcceleratorFilterTest, SearchKeyShortcutsAreAlwaysHandled) {
- TestSessionStateDelegate* session_state_delegate =
- AshTestHelper::GetTestSessionStateDelegate();
- EXPECT_FALSE(session_state_delegate->IsScreenLocked());
+ SessionController* const session_controller =
+ WmShell::Get()->session_controller();
+ EXPECT_FALSE(session_controller->IsScreenLocked());
ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow());
// We can lock the screen (Search+L) if a window is not present.
generator.PressKey(ui::VKEY_L, ui::EF_COMMAND_DOWN);
generator.ReleaseKey(ui::VKEY_L, ui::EF_COMMAND_DOWN);
- EXPECT_TRUE(session_state_delegate->IsScreenLocked());
+ session_controller->FlushMojoForTest(); // LockScreen is an async mojo call.
+ EXPECT_TRUE(session_controller->IsScreenLocked());
UnblockUserSession();
- EXPECT_FALSE(session_state_delegate->IsScreenLocked());
+ EXPECT_FALSE(session_controller->IsScreenLocked());
// Search+L is processed when the app_list target visibility is false.
Shell::Get()->DismissAppList();
EXPECT_FALSE(Shell::Get()->GetAppListTargetVisibility());
generator.PressKey(ui::VKEY_L, ui::EF_COMMAND_DOWN);
generator.ReleaseKey(ui::VKEY_L, ui::EF_COMMAND_DOWN);
- EXPECT_TRUE(session_state_delegate->IsScreenLocked());
+ session_controller->FlushMojoForTest(); // LockScreen is an async mojo call.
+ EXPECT_TRUE(session_controller->IsScreenLocked());
UnblockUserSession();
- EXPECT_FALSE(session_state_delegate->IsScreenLocked());
+ EXPECT_FALSE(session_controller->IsScreenLocked());
// Search+L is also processed when there is a full screen window.
aura::test::TestWindowDelegate window_delegate;
@@ -178,9 +180,10 @@ TEST_F(AcceleratorFilterTest, SearchKeyShortcutsAreAlwaysHandled) {
window->SetProperty(aura::client::kShowStateKey, ui::SHOW_STATE_FULLSCREEN);
generator.PressKey(ui::VKEY_L, ui::EF_COMMAND_DOWN);
generator.ReleaseKey(ui::VKEY_L, ui::EF_COMMAND_DOWN);
- EXPECT_TRUE(session_state_delegate->IsScreenLocked());
+ session_controller->FlushMojoForTest(); // LockScreen is an async mojo call.
+ EXPECT_TRUE(session_controller->IsScreenLocked());
UnblockUserSession();
- EXPECT_FALSE(session_state_delegate->IsScreenLocked());
+ EXPECT_FALSE(session_controller->IsScreenLocked());
}
} // namespace test
« no previous file with comments | « ash/accelerators/accelerator_controller_unittest.cc ('k') | ash/accelerators/accelerator_interactive_uitest_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698