Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2734923005: Implemented full support for NSAccessibilityLinkedUIElementsAttribute. (Closed)

Created:
3 years, 9 months ago by nektarios
Modified:
3 years, 9 months ago
CC:
aboxhall, aboxhall+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, dmazzoni+watch_chromium.org, dmazzoni, dtseng+watch_chromium.org, einbinder+watch-test-runner_chromium.org, haraken, jam, je_julie, jochen+watch_chromium.org, kinuko+watch, mac-reviews_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implemented full support for NSAccessibilityLinkedUIElementsAttribute. 1. In-page links now work, e.g. in the table of contents of a Wikipedia article. 2. Both native and ARIA radio buttons behave more consistently. BUG=37721 R=dmazzoni@chromium.org, ellyjones@chromium.org TESTED=layout test, browser tests, manually with Voiceover Review-Url: https://codereview.chromium.org/2734923005 Cr-Commit-Position: refs/heads/master@{#457695} Committed: https://chromium.googlesource.com/chromium/src/+/ee5dac5d4335b5f4fc6bd99136d38e7a070a4559

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebased with master. #

Patch Set 3 : Fixed formatting. #

Patch Set 4 : Fixed line formatting. #

Patch Set 5 : Fixed test. #

Total comments: 3

Patch Set 6 : and added all test expectations. #

Patch Set 7 : Moved code for fiinding ARIA radio buttons to Blink. #

Patch Set 8 : Fixed one test. #

Patch Set 9 : Only unignored radio buttons should be included. #

Patch Set 10 : Fixed two tests. #

Patch Set 11 : Fixed file path. #

Patch Set 12 : Fixed one more test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+419 lines, -18 lines) Patch
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 3 4 5 6 7 8 1 chunk +11 lines, -0 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 2 3 4 5 6 7 8 1 chunk +13 lines, -0 lines 0 comments Download
M content/shell/test_runner/web_ax_object_proxy.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/test_runner/web_ax_object_proxy.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-radiogroup.html View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
M content/test/data/accessibility/aria/aria-radiogroup-expected-android.txt View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
A content/test/data/accessibility/aria/aria-radiogroup-expected-blink.txt View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-radiogroup-expected-mac.txt View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/aria/aria-radiogroup-expected-win.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/html/a.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/html/a-expected-blink.txt View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/html/in-page-links.html View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A content/test/data/accessibility/html/in-page-links-expected-android.txt View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments Download
A content/test/data/accessibility/html/in-page-links-expected-blink.txt View 1 2 3 1 chunk +37 lines, -0 lines 0 comments Download
A content/test/data/accessibility/html/in-page-links-expected-mac.txt View 1 2 3 4 5 1 chunk +25 lines, -0 lines 0 comments Download
A content/test/data/accessibility/html/in-page-links-expected-win.txt View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
M content/test/data/accessibility/html/input-radio.html View 1 2 3 4 5 6 2 chunks +4 lines, -2 lines 0 comments Download
M content/test/data/accessibility/html/input-radio-expected-android.txt View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A content/test/data/accessibility/html/input-radio-expected-blink.txt View 1 2 3 4 5 6 7 1 chunk +13 lines, -0 lines 0 comments Download
M content/test/data/accessibility/html/input-radio-expected-mac.txt View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -4 lines 0 comments Download
M content/test/data/accessibility/html/input-radio-in-menu.html View 2 chunks +3 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/accessibility/in-page-link-target.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +83 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.h View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 2 3 4 5 6 7 8 9 6 chunks +93 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebAXObject.cpp View 1 2 chunks +20 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebAXObject.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/accessibility/ax_node_data.cc View 1 2 4 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 64 (45 generated)
nektarios
3 years, 9 months ago (2017-03-07 21:50:14 UTC) #1
Elly Fong-Jones
this is looking pretty good so far :) a few small things https://codereview.chromium.org/2734923005/diff/1/content/browser/accessibility/browser_accessibility_cocoa.mm File content/browser/accessibility/browser_accessibility_cocoa.mm ...
3 years, 9 months ago (2017-03-08 16:54:54 UTC) #2
blink-reviews
https://codereview.chromium.org/2734923005/diff/1/content/browser/accessibility/browser_accessibility_cocoa.mm > File content/browser/accessibility/browser_accessibility_cocoa.mm > (right): > > https://codereview.chromium.org/2734923005/diff/1/content/browser/accessibility/browser_accessibility_cocoa.mm#newcode1170 > content/browser/accessibility/browser_accessibility_cocoa.mm:1170: for > (size_t i ...
3 years, 9 months ago (2017-03-08 21:50:16 UTC) #3
chromium-reviews
https://codereview.chromium.org/2734923005/diff/1/content/browser/accessibility/browser_accessibility_cocoa.mm > File content/browser/accessibility/browser_accessibility_cocoa.mm > (right): > > https://codereview.chromium.org/2734923005/diff/1/content/browser/accessibility/browser_accessibility_cocoa.mm#newcode1170 > content/browser/accessibility/browser_accessibility_cocoa.mm:1170: for > (size_t i ...
3 years, 9 months ago (2017-03-08 21:50:17 UTC) #4
dmazzoni
Just one suggested code change, to search for the ARIA radio buttons in Blink code ...
3 years, 9 months ago (2017-03-09 19:15:04 UTC) #13
blink-reviews
1. Updated all test expectations. 2. Modified layout test to assert for role and name ...
3 years, 9 months ago (2017-03-09 19:51:35 UTC) #14
chromium-reviews
1. Updated all test expectations. 2. Modified layout test to assert for role and name ...
3 years, 9 months ago (2017-03-09 19:51:35 UTC) #15
nektarios
Move code that computes ARIA radio buttons to Blink. You may have another look.
3 years, 9 months ago (2017-03-09 23:48:38 UTC) #20
dmazzoni
lgtm
3 years, 9 months ago (2017-03-10 19:29:34 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734923005/180001
3 years, 9 months ago (2017-03-16 22:17:14 UTC) #44
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/387629)
3 years, 9 months ago (2017-03-16 22:27:04 UTC) #46
nektarios
@dglazkov or @pfeldman Could you review / rubberstamp changes to public/web and Source/web?
3 years, 9 months ago (2017-03-17 00:27:01 UTC) #48
pfeldman
lgtm
3 years, 9 months ago (2017-03-17 01:04:50 UTC) #49
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734923005/180001
3 years, 9 months ago (2017-03-17 01:05:57 UTC) #51
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/387798)
3 years, 9 months ago (2017-03-17 01:16:31 UTC) #53
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734923005/200001
3 years, 9 months ago (2017-03-17 01:54:21 UTC) #56
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/386140)
3 years, 9 months ago (2017-03-17 02:40:44 UTC) #58
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734923005/220001
3 years, 9 months ago (2017-03-17 03:21:12 UTC) #61
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 05:34:59 UTC) #64
Message was sent while issue was closed.
Committed patchset #12 (id:220001) as
https://chromium.googlesource.com/chromium/src/+/ee5dac5d4335b5f4fc6bd99136d3...

Powered by Google App Engine
This is Rietveld 408576698