runtime/vm/intermediate_language_ia32.cc - Issue 2734883002: ICData::NumberOfChecks is O(n) so don't call it in loops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 2734883002: ICData::NumberOfChecks is O(n) so don't call it in loops (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intermediate_language_ia32.cc

diff --git a/runtime/vm/intermediate_language_ia32.cc b/runtime/vm/intermediate_language_ia32.cc

index 1f4f4196af2cf7bd02993b5efd8d54233b6ead47..8cce18eb5aaba4b699616559e18478b22dcc3d35 100644

--- a/runtime/vm/intermediate_language_ia32.cc

+++ b/runtime/vm/intermediate_language_ia32.cc

@@ -5316,7 +5316,7 @@ void DoubleToIntegerInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

__ pushl(value_obj);

ASSERT(instance_call()->HasICData());

const ICData& ic_data = *instance_call()->ic_data();

- ASSERT((ic_data.NumberOfChecks() == 1));

+ ASSERT(ic_data.NumberOfChecksIs(1));

const Function& target = Function::ZoneHandle(ic_data.GetTargetAt(0));

const intptr_t kNumberOfArguments = 1;