Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // Copyright 2017 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_COMMAND_DISPATCHER_H_ | |
| 6 #define IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_COMMAND_DISPATCHER_H_ | |
| 7 | |
| 8 #import <Foundation/Foundation.h> | |
| 9 | |
| 10 // CommandDispatcher allows coordinators to register as command handlers for | |
| 11 // specific selectors. Other objects can call these methods on the dispatcher, | |
| 12 // which in turn will forward the call to the registered handler. | |
| 13 @interface CommandDispatcher : NSObject | |
|
marq (ping after 24h)
2017/03/16 13:54:46
Doesn't CommandDispatcher need to publicly conform
lpromero
2017/03/21 15:15:32
This is discussed upthread.
| |
| 14 | |
| 15 // Registers the given |target| to receive forwarded messages for the given | |
| 16 // |selector|. | |
| 17 - (void)registerTarget:(id)target forSelector:(SEL)selector; | |
|
lpromero
2017/03/10 16:17:36
The comment doesn't specify that you can't have se
| |
| 18 | |
| 19 // Removes all forwarding registrations for the given |target|. | |
| 20 - (void)stopDispatchingForTarget:(id)target; | |
|
lpromero
2017/03/09 16:16:30
s/…/unregisterTarget: ?
rohitrao (ping after 24h)
2017/03/10 14:44:31
I went through a number of iterations:
unregisterT
lpromero
2017/03/10 16:17:36
Handler might convey more that fact that we can on
marq (ping after 24h)
2017/03/16 13:54:46
I like -stopDispatching:, so much that I'd like to
lpromero
2017/03/21 15:15:32
https://codereview.chromium.org/2766663002/
| |
| 21 | |
| 22 @end | |
| 23 | |
| 24 #endif // IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_COMMAND_DISPATCHER_H_ | |
| OLD | NEW |