Update scheme text color in Omnibox only in non-default Security Levels

chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
index 689b651ed518fc723481d9294126be3eee28c176..885da389cf09cdd82d402a476f9ba06a14eef889 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
@@ -574,6 +574,9 @@ void OmniboxViewViews::SetEmphasis(bool emphasize, const gfx::Range& range) {
 
 void OmniboxViewViews::UpdateSchemeStyle(const gfx::Range& range) {
   DCHECK(range.IsValid());
+  // Scheme color is only overridden for non-default security levels.

[Peter Kasting, 2017/03/08 03:05:44]

Mac also does this check.  Maybe we should pass the security level to
UpdateTextStyle() so it can do this.

It would also be good to explain this better.  This comment talks about "what",
which I can kind of gather from the code, but it doesn't talk about "why", which
honestly is a bit unclear to me as well.

[elawrence, 2017/03/08 17:23:03]

I've updated the comment. 

Passing the security level up to UpdateTextStyle would require a significant
refactoring because we currently get the level in different ways on Mac vs.
Views, and we'd either need to pass it back down to UpdateSchemeStyle or create
a new set of flag arguments to UpdateSchemeStyle that explain exactly what we
want to have done (StrikeThrough|WarnColor, PlainText|EVColor) etc. 

I feel pretty good about the current code; it's much simpler than it was prior
to this effort and now iOS/Mac/Views are all very similar, with small functions
implementing the platform specific pieces.

+  if (security_level_ == security_state::NONE)
+    return;
   const SkColor security_color =
       location_bar_view_->GetSecureTextColor(security_level_);
   const bool strike = security_level_ == security_state::DANGEROUS;