Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2579)

Unified Diff: content/shell/test_runner/web_view_test_proxy.cc

Issue 2734713002: WebViewTestProxyBase: clear out main test delegate upon destruction. (Closed)
Patch Set: undo ps#2 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/test_runner/mock_web_speech_recognizer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/test_runner/web_view_test_proxy.cc
diff --git a/content/shell/test_runner/web_view_test_proxy.cc b/content/shell/test_runner/web_view_test_proxy.cc
index 140400368a580530b646ff4ab342f4d76ccd43de..3fdc4561976e58938a37b020849e2000f8e7c5e8 100644
--- a/content/shell/test_runner/web_view_test_proxy.cc
+++ b/content/shell/test_runner/web_view_test_proxy.cc
@@ -32,6 +32,8 @@ WebViewTestProxyBase::WebViewTestProxyBase()
WebViewTestProxyBase::~WebViewTestProxyBase() {
test_interfaces_->WindowClosed(this);
+ if (test_interfaces_->GetDelegate() == delegate_)
+ test_interfaces_->SetDelegate(nullptr);
tasak 2017/03/07 03:06:01 I think, this breaks "--single-process". Received
}
void WebViewTestProxyBase::SetInterfaces(WebTestInterfaces* interfaces) {
« no previous file with comments | « content/shell/test_runner/mock_web_speech_recognizer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698