Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Unified Diff: ash/common/system/chromeos/network/vpn_list_unittest.cc

Issue 2734653002: chromeos: Move files in //ash/common to //ash (Closed)
Patch Set: fix a11y tests, fix docs Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/system/chromeos/network/vpn_list.cc ('k') | ash/common/system/chromeos/network/vpn_list_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/system/chromeos/network/vpn_list_unittest.cc
diff --git a/ash/common/system/chromeos/network/vpn_list_unittest.cc b/ash/common/system/chromeos/network/vpn_list_unittest.cc
deleted file mode 100644
index 1da37228b64e5021623b7748e2831767f1170b13..0000000000000000000000000000000000000000
--- a/ash/common/system/chromeos/network/vpn_list_unittest.cc
+++ /dev/null
@@ -1,99 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "ash/common/system/chromeos/network/vpn_list.h"
-
-#include <algorithm>
-#include <vector>
-
-#include "ash/public/interfaces/vpn_list.mojom.h"
-#include "base/macros.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-using ash::mojom::ThirdPartyVpnProvider;
-using ash::mojom::ThirdPartyVpnProviderPtr;
-
-namespace ash {
-
-namespace {
-
-class TestVpnListObserver : public VpnList::Observer {
- public:
- TestVpnListObserver() {}
- ~TestVpnListObserver() override {}
-
- // VpnList::Observer:
- void OnVPNProvidersChanged() override { change_count_++; }
-
- int change_count_ = 0;
-};
-
-} // namespace
-
-using VpnListTest = testing::Test;
-
-TEST_F(VpnListTest, BuiltInProvider) {
- VpnList vpn_list;
-
- // The VPN list should only contain the built-in provider.
- ASSERT_EQ(1u, vpn_list.vpn_providers().size());
- VPNProvider provider = vpn_list.vpn_providers()[0];
- EXPECT_FALSE(provider.third_party);
- EXPECT_TRUE(provider.extension_id.empty());
-}
-
-TEST_F(VpnListTest, ThirdPartyProviders) {
- VpnList vpn_list;
-
- // The VPN list should only contain the built-in provider.
- EXPECT_EQ(1u, vpn_list.vpn_providers().size());
-
- // Add some third party (extension-backed) providers.
- std::vector<ThirdPartyVpnProviderPtr> third_party_providers;
- ThirdPartyVpnProviderPtr third_party1 = ThirdPartyVpnProvider::New();
- third_party1->name = "name1";
- third_party1->extension_id = "extension_id1";
- third_party_providers.push_back(std::move(third_party1));
-
- ThirdPartyVpnProviderPtr third_party2 = ThirdPartyVpnProvider::New();
- third_party2->name = "name2";
- third_party2->extension_id = "extension_id2";
- third_party_providers.push_back(std::move(third_party2));
-
- vpn_list.SetThirdPartyVpnProviders(std::move(third_party_providers));
-
- // Mojo types will be converted to internal ash types.
- VPNProvider provider1("extension_id1", "name1");
- VPNProvider provider2("extension_id2", "name2");
-
- // List contains the extension-backed providers. Order doesn't matter.
- std::vector<VPNProvider> providers = vpn_list.vpn_providers();
- EXPECT_EQ(3u, providers.size());
- EXPECT_EQ(1u, std::count(providers.begin(), providers.end(), provider1));
- EXPECT_EQ(1u, std::count(providers.begin(), providers.end(), provider2));
-}
-
-TEST_F(VpnListTest, Observers) {
- VpnList vpn_list;
-
- // Observers are not notified when they are added.
- TestVpnListObserver observer;
- vpn_list.AddObserver(&observer);
- EXPECT_EQ(0, observer.change_count_);
-
- // Add a third party (extension-backed) provider.
- std::vector<ThirdPartyVpnProviderPtr> third_party_providers;
- ThirdPartyVpnProviderPtr third_party1 = ThirdPartyVpnProvider::New();
- third_party1->name = "name1";
- third_party1->extension_id = "extension_id1";
- third_party_providers.push_back(std::move(third_party1));
- vpn_list.SetThirdPartyVpnProviders(std::move(third_party_providers));
-
- // Observer was notified.
- EXPECT_EQ(1, observer.change_count_);
-
- vpn_list.RemoveObserver(&observer);
-}
-
-} // namespace ash
« no previous file with comments | « ash/common/system/chromeos/network/vpn_list.cc ('k') | ash/common/system/chromeos/network/vpn_list_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698