Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3838)

Unified Diff: cc/layers/solid_color_scrollbar_layer.cc

Issue 2734583002: Do not ignore SolidColorScrollbarLayer's scroll_layer_id ctor argument (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/scrollbar_layer_unittest.cc ('k') | cc/trees/layer_tree_host_unittest_damage.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/solid_color_scrollbar_layer.cc
diff --git a/cc/layers/solid_color_scrollbar_layer.cc b/cc/layers/solid_color_scrollbar_layer.cc
index 2670fd3216541303f711bbbfcf22b8d98b3b3b29..2eb5484c855035419083a89ce65e147cff1a62f2 100644
--- a/cc/layers/solid_color_scrollbar_layer.cc
+++ b/cc/layers/solid_color_scrollbar_layer.cc
@@ -39,7 +39,7 @@ SolidColorScrollbarLayer::SolidColorScrollbarLayerInputs::
int track_start,
bool is_left_side_vertical_scrollbar,
int scroll_layer_id)
ajuma 2017/03/04 00:04:50 It looks like this gets called in non-test code wi
pdr. 2017/03/04 02:44:23 We can actually do even better: these callsites ar
- : scroll_layer_id(Layer::INVALID_ID),
+ : scroll_layer_id(scroll_layer_id),
orientation(orientation),
thumb_thickness(thumb_thickness),
track_start(track_start),
« no previous file with comments | « cc/layers/scrollbar_layer_unittest.cc ('k') | cc/trees/layer_tree_host_unittest_damage.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698