Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: third_party/WebKit/LayoutTests/external/wpt/IndexedDB/fire-success-event-exception.html

Issue 2734533002: IndexedDB: Align abort behavior on uncaught exception with Gecko (Closed)
Patch Set: Test refactors per review Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/external/wpt/IndexedDB/fire-success-event-exception.html
diff --git a/third_party/WebKit/LayoutTests/external/wpt/IndexedDB/fire-success-event-exception.html b/third_party/WebKit/LayoutTests/external/wpt/IndexedDB/fire-success-event-exception.html
new file mode 100644
index 0000000000000000000000000000000000000000..c4e55066bbab9069e744c089f81df0714ad4db19
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/external/wpt/IndexedDB/fire-success-event-exception.html
@@ -0,0 +1,72 @@
+<!DOCTYPE html>
+<meta charset=utf-8>
+<title>Fire success event - Exception thrown</title>
+<link rel="help" href="https://w3c.github.io/IndexedDB/#fire-success-event">
+<script src=/resources/testharness.js></script>
+<script src=/resources/testharnessreport.js></script>
+<script src=support.js></script>
+<script>
+setup({allow_uncaught_exception:true});
+
+function fire_success_event_test(func, description) {
+ indexeddb_test(
+ (t, db) => {
+ db.createObjectStore('s');
+ },
+ (t, db) => {
+ const tx = db.transaction('s');
+ tx.oncomplete = t.unreached_func('transaction should abort');
+ const store = tx.objectStore('s');
+ const request = store.get(0);
+ func(t, db, tx, request);
+ },
+ description);
+}
+
+fire_success_event_test((t, db, tx, request) => {
+ request.onsuccess = () => {
+ throw Error();
+ };
+ tx.onabort = t.step_func_done(() => {
+ assert_equals(tx.error.name, 'AbortError');
+ });
+}, 'Exception in success event handler on request');
+
+fire_success_event_test((t, db, tx, request) => {
+ request.addEventListener('success', () => {
+ throw Error();
+ });
+ tx.onabort = t.step_func_done(() => {
+ assert_equals(tx.error.name, 'AbortError');
+ });
+}, 'Exception in success event listener on request');
+
+fire_success_event_test((t, db, tx, request) => {
+ request.addEventListener('success', () => {
+ // no-op
+ });
+ request.addEventListener('success', () => {
+ throw Error();
+ });
+ tx.onabort = t.step_func_done(() => {
+ assert_equals(tx.error.name, 'AbortError');
+ });
+}, 'Exception in second success event listener on request');
+
+fire_success_event_test((t, db, tx, request) => {
+ let second_listener_called = false;
+ request.addEventListener('success', () => {
+ throw Error();
+ });
+ request.addEventListener('success', t.step_func(() => {
+ second_listener_called = true;
+ assert_true(is_transaction_active(tx, 's'),
+ 'Transaction should be active until dispatch completes');
+ }));
+ tx.onabort = t.step_func_done(() => {
+ assert_true(second_listener_called);
+ assert_equals(tx.error.name, 'AbortError');
+ });
+}, 'Exception in first success event listener, tx active in second');
+
+</script>

Powered by Google App Engine
This is Rietveld 408576698