Chromium Code Reviews Chromium Code Reviews
Issue 2734533002:
IndexedDB: Align abort behavior on uncaught exception with Gecko (Closed)
| Index: third_party/WebKit/LayoutTests/external/wpt/IndexedDB/fire-upgradeneeded-event-exception.html |
| diff --git a/third_party/WebKit/LayoutTests/external/wpt/IndexedDB/fire-upgradeneeded-event-exception.html b/third_party/WebKit/LayoutTests/external/wpt/IndexedDB/fire-upgradeneeded-event-exception.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..db078a539fcc8f6c966eb6bb7d8cfad007479be8 |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/external/wpt/IndexedDB/fire-upgradeneeded-event-exception.html |
| @@ -0,0 +1,86 @@ |
| +<!DOCTYPE html> |
| +<meta charset=utf-8> |
| +<title>Fire upgradeneeded event - Exception thrown</title> |
| +<script src=/resources/testharness.js></script> |
| +<script src=/resources/testharnessreport.js></script> |
| +<script src=support.js></script> |
| +<script> |
| +setup({allow_uncaught_exception:true}); |
|
pwnall
2017/03/04 00:27:33
Cool, I didn't know about this. I may need to add
|
| + |
| +async_test(t => { |
| + const dbname = document.location + '-' + t.name; |
| + const del = indexedDB.deleteDatabase(dbname); |
| + del.onerror = t.unreached_func('deleteDatabase should succeed'); |
| + const open = indexedDB.open(dbname, 1); |
| + let tx; |
| + open.onupgradeneeded = () => { |
| + tx = open.transaction; |
| + throw Error(); |
| + }; |
| + open.onsuccess = t.unreached_func('open should fail'); |
| + open.onerror = t.step_func_done(() => { |
| + assert_equals(tx.error.name, 'AbortError'); |
| + }); |
| +}, 'Exception in upgradeneeded handler'); |
| + |
| +async_test(t => { |
| + const dbname = document.location + '-' + t.name; |
| + const del = indexedDB.deleteDatabase(dbname); |
| + del.onerror = t.unreached_func('deleteDatabase should succeed'); |
| + const open = indexedDB.open(dbname, 1); |
| + let tx; |
| + open.addEventListener('upgradeneeded', () => { |
| + tx = open.transaction; |
| + throw Error(); |
| + }); |
| + open.onsuccess = t.unreached_func('open should fail'); |
| + open.onerror = t.step_func_done(() => { |
| + assert_equals(tx.error.name, 'AbortError'); |
| + }); |
| +}, 'Exception in upgradeneeded listener'); |
| + |
| +async_test(t => { |
| + const dbname = document.location + '-' + t.name; |
| + const del = indexedDB.deleteDatabase(dbname); |
| + del.onerror = t.unreached_func('deleteDatabase should succeed'); |
| + const open = indexedDB.open(dbname, 1); |
| + let tx; |
| + open.addEventListener('upgradeneeded', () => { |
| + // No-op. |
| + }); |
| + open.addEventListener('upgradeneeded', () => { |
| + tx = open.transaction; |
| + throw Error(); |
| + }); |
| + open.onsuccess = t.unreached_func('open should fail'); |
| + open.onerror = t.step_func_done(() => { |
| + assert_equals(tx.error.name, 'AbortError'); |
| + }); |
| +}, 'Exception in second upgradeneeded listener'); |
| + |
| +async_test(t => { |
| + const dbname = document.location + '-' + t.name; |
| + const del = indexedDB.deleteDatabase(dbname); |
| + del.onerror = t.unreached_func('deleteDatabase should succeed'); |
| + const open = indexedDB.open(dbname, 1); |
| + let store; |
|
pwnall
2017/03/04 00:27:33
I don't think you use store outside the block in 7
jsbell
2017/03/06 18:25:02
Thanks, left over from some refactoring. Removed.
|
| + let tx; |
| + let second_listener_called = false; |
| + open.addEventListener('upgradeneeded', () => { |
| + store = open.result.createObjectStore('s'); |
| + throw Error(); |
| + }); |
| + open.addEventListener('upgradeneeded', t.step_func(() => { |
| + second_listener_called = true; |
| + tx = open.transaction; |
| + assert_true(is_transaction_active(tx, 's'), |
| + 'Transaction should be active until dispatch completes'); |
| + })); |
| + open.onsuccess = t.unreached_func('open should fail'); |
| + open.onerror = t.step_func_done(() => { |
| + assert_true(second_listener_called); |
| + assert_equals(tx.error.name, 'AbortError'); |
| + }); |
| +}, 'Exception in first upgradeneeded listener, tx active in second'); |
| + |
| +</script> |
