Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 2734343002: Turn the DOWN_CAST_COMPOSITE strong mode error into a hint, which will (Closed)

Created:
3 years, 9 months ago by kasperl
Modified:
3 years, 9 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Turn the DOWN_CAST_COMPOSITE strong mode error into a hint, which will hide it unless you use an analysis options file to promote it to a warning or an error. R=vsm@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/fa2a3a1afa1a1e0eb748783472b25214d53aceec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/analyzer/lib/src/error/codes.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
kasperl
3 years, 9 months ago (2017-03-08 13:37:36 UTC) #1
vsm
lgtm
3 years, 9 months ago (2017-03-08 13:39:37 UTC) #2
kasperl
3 years, 9 months ago (2017-03-08 21:47:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fa2a3a1afa1a1e0eb748783472b25214d53aceec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698