Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/clean/chrome/browser/ui/settings/settings_coordinator.mm

Issue 2734333003: Child coordinators notify their parent upon -start and -stop. (Closed)
Patch Set: Feedback Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ios/clean/chrome/browser/browser_coordinator+internal.h ('K') | « ios/clean/chrome/browser/ui/ntp/new_tab_page_coordinator.mm ('k') | ios/clean/chrome/browser/ui/tab/tab_coordinator.mm » ('j') | ios/clean/chrome/browser/ui/tab/tab_coordinator.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/clean/chrome/browser/ui/settings/settings_coordinator.mm
diff --git a/ios/clean/chrome/browser/ui/settings/settings_coordinator.mm b/ios/clean/chrome/browser/ui/settings/settings_coordinator.mm
index 536bebce76998e91faa919d4ea2d4882132e90af..46a0fc989556fa8701ad674f6a9aae562acc0dfe 100644
--- a/ios/clean/chrome/browser/ui/settings/settings_coordinator.mm
+++ b/ios/clean/chrome/browser/ui/settings/settings_coordinator.mm
@@ -38,9 +38,11 @@
[self.context.baseViewController presentViewController:self.viewController
animated:self.context.animated
completion:nil];
+ [super start];
}
- (void)stop {
+ [super stop];
[self.viewController.presentingViewController
dismissViewControllerAnimated:self.context.animated
completion:nil];
« ios/clean/chrome/browser/browser_coordinator+internal.h ('K') | « ios/clean/chrome/browser/ui/ntp/new_tab_page_coordinator.mm ('k') | ios/clean/chrome/browser/ui/tab/tab_coordinator.mm » ('j') | ios/clean/chrome/browser/ui/tab/tab_coordinator.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698