Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Unified Diff: ios/clean/chrome/browser/ui/tab/tab_coordinator.mm

Issue 2734333003: Child coordinators notify their parent upon -start and -stop. (Closed)
Patch Set: Fix tests build (they were on the "all" target) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/clean/chrome/browser/ui/tab/tab_coordinator.mm
diff --git a/ios/clean/chrome/browser/ui/tab/tab_coordinator.mm b/ios/clean/chrome/browser/ui/tab/tab_coordinator.mm
index 3ccbaa66b67e257ec66db055332433efb9e04f11..df2083035c1e27d111ec04940bd536f08a0fbf8b 100644
--- a/ios/clean/chrome/browser/ui/tab/tab_coordinator.mm
+++ b/ios/clean/chrome/browser/ui/tab/tab_coordinator.mm
@@ -91,9 +91,11 @@ const BOOL kUseBottomToolbar = NO;
[self.context.baseViewController presentViewController:self.viewController
animated:self.context.animated
completion:nil];
+ [super start];
}
- (void)stop {
+ [super stop];
[self.viewController.presentingViewController
dismissViewControllerAnimated:self.context.animated
completion:nil];

Powered by Google App Engine
This is Rietveld 408576698