Issue 273433002: Revert "Prevent liveedit on or under generators with open activations"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 273433002: Revert "Prevent liveedit on or under generators with open activations" (Closed)

Created:
6 years, 7 months ago by rossberg

Modified:
6 years, 7 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "Prevent liveedit on or under generators with open activations" Seems to crash some tests on buildbots. TBR=ishell@chromium.org CC=wingo@igalia.com,yangguo@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=21178

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -221 lines)			Patch
M	src/liveedit.h	View	2 chunks	+1 line, -8 lines	0 comments	Download
M	src/liveedit.cc	View	6 chunks	+19 lines, -77 lines	0 comments	Download
M	src/liveedit-debugger.js	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
D	test/mjsunit/harmony/generators-debug-liveedit.js	View	1 chunk	+0 lines, -119 lines	0 comments	Download
M	test/mjsunit/mjsunit.status	View	4 chunks	+0 lines, -4 lines	0 comments	Download

Total messages: 1 (0 generated)

rossberg

6 years, 7 months ago (2014-05-06 16:02:27 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r21178 (presubmit successful).