Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2734323002: [dart:io][windows] Set Console VT modes (Closed)

Created:
3 years, 9 months ago by zra
Modified:
3 years, 9 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[dart:io][windows] Set Console VT modes Though, apparently this only works for Windows 10. Windows 7 doesn't support the needed VT modes. related #28984,#28614 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/92b746cd439d94a0ffea7f8bf45669c407acdc96

Patch Set 1 #

Patch Set 2 : Add a comment with a doc link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -4 lines) Patch
M runtime/bin/platform_win.cc View 1 4 chunks +40 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
zra
3 years, 9 months ago (2017-03-08 17:55:26 UTC) #3
rmacnak
lgtm
3 years, 9 months ago (2017-03-08 18:40:41 UTC) #4
zra
3 years, 9 months ago (2017-03-08 19:02:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
92b746cd439d94a0ffea7f8bf45669c407acdc96 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698