Issue 27343002: Second wave of Win64 warning cleanup

Issue 27343002: Second wave of Win64 warning cleanup (Closed)

Created:
7 years, 2 months ago by robertphillips

Modified:
7 years, 2 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Second wave of Win64 warning cleanup In service of Skia issue 1695 (64-bit Mac and Windows bots reporting warnings - https://code.google.com/p/skia/issues/detail?id=1695)

Patch Set 4 : Now compiling on Linux #

Total comments: 2

Patch Set 5 : switched count_glyphs back to int #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+104 lines, -106 lines)			Patch
M	bench/FontCacheBench.cpp	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/core/SkPictureRecord.h	View	1 2 3	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/core/SkPictureRecord.cpp	View	1 2 3	20 chunks	+70 lines, -70 lines	0 comments	Download
M	src/gpu/GrAtlas.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrAtlas.cpp	View	1 2 3	2 chunks	+5 lines, -7 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	1 2 3	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/gpu/GrTextStrike_impl.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gr_unittests.cpp	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/images/SkImageDecoder_libwebp.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/images/SkJpegUtility.cpp	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pdf/SkPDFResourceDict.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pdf/SkTSet.h	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pipe/SkGPipeWrite.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ports/SkFontHost_win.cpp	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/ports/SkImageDecoder_WIC.cpp	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/utils/SkCanvasStateUtils.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/utils/SkNinePatch.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/views/win/SkOSWindow_win.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/skdiff_utils.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bsalomon

https://codereview.chromium.org/27343002/diff/8001/bench/FontCacheBench.cpp File bench/FontCacheBench.cpp (right): https://codereview.chromium.org/27343002/diff/8001/bench/FontCacheBench.cpp#newcode18 bench/FontCacheBench.cpp:18: static size_t count_glyphs(const uint16_t start[]) { this one looks ...

7 years, 2 months ago (2013-10-15 17:35:20 UTC) #2

robertphillips

7 years, 2 months ago (2013-10-15 17:47:53 UTC) #3

Message was sent while issue was closed.

committed as r11778

https://codereview.chromium.org/27343002/diff/8001/bench/FontCacheBench.cpp
File bench/FontCacheBench.cpp (right):

https://codereview.chromium.org/27343002/diff/8001/bench/FontCacheBench.cpp#n...
bench/FontCacheBench.cpp:18: static size_t count_glyphs(const uint16_t start[])
{
On 2013/10/15 17:35:20, bsalomon wrote:
> this one looks like an int count to me, rest lgtm

Done.

Expand Messages | Collapse Messages