Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1166)

Unified Diff: chrome/common/extensions/api/identity.idl

Issue 273423005: Add best practice tip to identity API launchWebAuthFlow. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/identity.idl
diff --git a/chrome/common/extensions/api/identity.idl b/chrome/common/extensions/api/identity.idl
index 10c73422a313b13f193ad79d960d5159ff87e7c1..5f018bd2f979ae2c9dedf036b66d4e8fa17bf4bb 100644
--- a/chrome/common/extensions/api/identity.idl
+++ b/chrome/common/extensions/api/identity.idl
@@ -87,6 +87,13 @@ namespace identity {
// window will close, and the final redirect URL will be passed to
// the <var>callback</var> function.
//
+ // For a good user experience it is important interactive auth flows are
+ // initiated by UI in your app explaining what the authorization is for.
+ // Failing to do this will cause your users to get authorization requests
+ // - or even Chrome sign in screens if they are not signed in - with
+ // no context. In particular, do not launch an interactive auth flow when
+ // your app is first launched.
+ //
// |details| : WebAuth flow options.
// |callback| : Called with the URL redirected back to your application.
static void launchWebAuthFlow(WebAuthFlowDetails details,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698