Issue 273423005: Add best practice tip to identity API launchWebAuthFlow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 273423005: Add best practice tip to identity API launchWebAuthFlow. (Closed)

Created:
6 years, 7 months ago by benwells

Modified:
6 years, 7 months ago

Reviewers:
Michael Courage

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add best practice tip to identity API launchWebAuthFlow. The tip is to suggest auth flows are initiated from app UI explaining why. Without this, if a signed out user launches an app that immediately initiates an interactive auth session, the first thing the user sees is a chrome signin screen. BUG=372279 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269963

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	chrome/common/extensions/api/identity.idl	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/273423005/1

6 years, 7 months ago (2014-05-12 21:30:38 UTC) #4

Message was sent while issue was closed.

Change committed as 269963

Expand Messages | Collapse Messages