Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1440)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 273423004: Migrate accessibility from RenderView to RenderFrame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm
index 402df2f8184557c5c114e6dd8116884b340910dc..213cbd15f07502c3ffdfa372c688b951255a71f2 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
@@ -2048,14 +2048,13 @@ void RenderWidgetHostViewMac::SetBackgroundOpaque(bool opaque) {
render_widget_host_->SetBackgroundOpaque(opaque);
}
-void RenderWidgetHostViewMac::CreateBrowserAccessibilityManagerIfNeeded() {
- if (!GetBrowserAccessibilityManager()) {
- SetBrowserAccessibilityManager(
- new BrowserAccessibilityManagerMac(
- cocoa_view_,
- BrowserAccessibilityManagerMac::GetEmptyDocument(),
- render_widget_host_));
- }
+BrowserAccessibilityManager*
+ RenderWidgetHostViewMac::CreateBrowserAccessibilityManager(
+ BrowserAccessibilityDelegate* delegate) {
+ return new BrowserAccessibilityManagerMac(
+ cocoa_view_,
+ BrowserAccessibilityManagerMac::GetEmptyDocument(),
+ delegate);
}
gfx::Point RenderWidgetHostViewMac::AccessibilityOriginInScreen(
@@ -2070,33 +2069,9 @@ gfx::Point RenderWidgetHostViewMac::AccessibilityOriginInScreen(
return gfx::Point(originInScreen.x, originInScreen.y);
}
-void RenderWidgetHostViewMac::OnAccessibilitySetFocus(int accObjId) {
- // Immediately set the focused item even though we have not officially set
- // focus on it as VoiceOver expects to get the focused item after this
- // method returns.
- BrowserAccessibilityManager* manager = GetBrowserAccessibilityManager();
- if (manager)
- manager->SetFocus(manager->GetFromID(accObjId), false);
-}
-
-void RenderWidgetHostViewMac::AccessibilityShowMenu(int accObjId) {
- BrowserAccessibilityManager* manager = GetBrowserAccessibilityManager();
- if (!manager)
- return;
- BrowserAccessibilityCocoa* obj =
- manager->GetFromID(accObjId)->ToBrowserAccessibilityCocoa();
-
- // Performs a right click copying WebKit's
- // accessibilityPerformShowMenuAction.
- NSPoint objOrigin = [obj origin];
- NSSize size = [[obj size] sizeValue];
- gfx::Point origin = AccessibilityOriginInScreen(
- gfx::Rect(objOrigin.x, objOrigin.y, size.width, size.height));
- NSPoint location = NSMakePoint(origin.x(), origin.y());
+void RenderWidgetHostViewMac::AccessibilityShowMenu(const gfx::Point& point) {
+ NSPoint location = NSMakePoint(point.x(), point.y());
location = [[cocoa_view_ window] convertScreenToBase:location];
- location.x += size.width/2;
- location.y += size.height/2;
-
NSEvent* fakeRightClick = [NSEvent
mouseEventWithType:NSRightMouseDown
location:location
@@ -2111,8 +2086,6 @@ void RenderWidgetHostViewMac::AccessibilityShowMenu(int accObjId) {
[cocoa_view_ mouseEvent:fakeRightClick];
}
-
-
void RenderWidgetHostViewMac::SetTextInputActive(bool active) {
if (active) {
if (text_input_type_ == ui::TEXT_INPUT_TYPE_PASSWORD)
@@ -3205,7 +3178,7 @@ void RenderWidgetHostViewMac::OnDisplayMetricsChanged(
- (id)accessibilityAttributeValue:(NSString *)attribute {
BrowserAccessibilityManager* manager =
- renderWidgetHostView_->GetBrowserAccessibilityManager();
+ renderWidgetHostView_->GetHost()->GetRootBrowserAccessibilityManager();
// Contents specifies document view of RenderWidgetHostViewCocoa provided by
// BrowserAccessibilityManager. Children includes all subviews in addition to
@@ -3230,25 +3203,28 @@ void RenderWidgetHostViewMac::OnDisplayMetricsChanged(
}
- (id)accessibilityHitTest:(NSPoint)point {
- if (!renderWidgetHostView_->GetBrowserAccessibilityManager())
+ BrowserAccessibilityManager* manager =
+ renderWidgetHostView_->GetHost()->GetRootBrowserAccessibilityManager();
+ if (!manager)
return self;
NSPoint pointInWindow = [[self window] convertScreenToBase:point];
NSPoint localPoint = [self convertPoint:pointInWindow fromView:nil];
localPoint.y = NSHeight([self bounds]) - localPoint.y;
- BrowserAccessibilityCocoa* root = renderWidgetHostView_->
- GetBrowserAccessibilityManager()->
- GetRoot()->ToBrowserAccessibilityCocoa();
+ BrowserAccessibilityCocoa* root =
+ manager->GetRoot()->ToBrowserAccessibilityCocoa();
id obj = [root accessibilityHitTest:localPoint];
return obj;
}
- (BOOL)accessibilityIsIgnored {
- return !renderWidgetHostView_->GetBrowserAccessibilityManager();
+ BrowserAccessibilityManager* manager =
+ renderWidgetHostView_->GetHost()->GetRootBrowserAccessibilityManager();
+ return !manager;
}
- (NSUInteger)accessibilityGetIndexOf:(id)child {
BrowserAccessibilityManager* manager =
- renderWidgetHostView_->GetBrowserAccessibilityManager();
+ renderWidgetHostView_->GetHost()->GetRootBrowserAccessibilityManager();
// Only child is root.
if (manager &&
manager->GetRoot()->ToBrowserAccessibilityCocoa() == child) {
@@ -3260,7 +3236,7 @@ void RenderWidgetHostViewMac::OnDisplayMetricsChanged(
- (id)accessibilityFocusedUIElement {
BrowserAccessibilityManager* manager =
- renderWidgetHostView_->GetBrowserAccessibilityManager();
+ renderWidgetHostView_->GetHost()->GetRootBrowserAccessibilityManager();
if (manager) {
BrowserAccessibility* focused_item = manager->GetFocus(NULL);
DCHECK(focused_item);
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_mac.h ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698