Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: content/renderer/render_view_impl.h

Issue 273423004: Migrate accessibility from RenderView to RenderFrame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.h
diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h
index cf01b135efd5140ba84081fbafab28cb56b0002a..af7bfd6e8eb5c48ca4f0dd5b801d635dad3a7abf 100644
--- a/content/renderer/render_view_impl.h
+++ b/content/renderer/render_view_impl.h
@@ -140,7 +140,6 @@ class PepperPluginInstanceImpl;
class RenderViewImplTest;
class RenderViewObserver;
class RenderViewTest;
-class RendererAccessibility;
class RendererDateTimePicker;
class RendererWebColorChooserImpl;
class SpeechRecognitionDispatcher;
@@ -186,8 +185,7 @@ class CONTENT_EXPORT RenderViewImpl
bool hidden,
bool never_visible,
int32 next_page_id,
- const blink::WebScreenInfo& screen_info,
- AccessibilityMode accessibility_mode);
+ const blink::WebScreenInfo& screen_info);
// Used by content_layouttest_support to hook into the creation of
// RenderViewImpls.
@@ -226,14 +224,6 @@ class CONTENT_EXPORT RenderViewImpl
return media_stream_dispatcher_;
}
- AccessibilityMode accessibility_mode() {
- return accessibility_mode_;
- }
-
- RendererAccessibility* renderer_accessibility() {
- return renderer_accessibility_;
- }
-
MouseLockDispatcher* mouse_lock_dispatcher() {
return mouse_lock_dispatcher_;
}
@@ -576,9 +566,9 @@ class CONTENT_EXPORT RenderViewImpl
// For unit tests.
friend class ExternalPopupMenuTest;
friend class PepperDeviceTest;
- friend class RendererAccessibilityTest;
friend class RenderViewImplTest;
friend class RenderViewTest;
+ friend class RendererAccessibilityTest;
// TODO(nasko): Temporarily friend RenderFrameImpl, so we don't duplicate
// utility functions needed in both classes, while we move frame specific
@@ -602,7 +592,7 @@ class CONTENT_EXPORT RenderViewImpl
FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, OnHandleKeyboardEvent);
FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, OnImeTypeChanged);
FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, OnNavStateChanged);
- FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, OnSetAccessibilityMode);
+ //FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, OnSetAccessibilityMode);
ncarter (slow) 2014/07/15 01:23:29 Just delete this line?
dmazzoni 2014/07/15 07:55:04 Thanks, done.
FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, OnSetTextDirection);
FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, OnUpdateWebPreferences);
FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest,
@@ -727,7 +717,6 @@ class CONTENT_EXPORT RenderViewImpl
void OnPostMessageEvent(const ViewMsg_PostMessage_Params& params);
void OnReleaseDisambiguationPopupBitmap(const cc::SharedBitmapId& id);
void OnResetPageEncodingToDefault();
- void OnSetAccessibilityMode(AccessibilityMode new_mode);
void OnSetActive(bool active);
void OnSetBackgroundOpaque(bool opaque);
void OnExitFullscreen();
@@ -1051,13 +1040,6 @@ class CONTENT_EXPORT RenderViewImpl
DevToolsAgent* devtools_agent_;
- // The current accessibility mode.
- AccessibilityMode accessibility_mode_;
-
- // Only valid if |accessibility_mode_| is anything other than
- // AccessibilityModeOff.
- RendererAccessibility* renderer_accessibility_;
-
// Mouse Lock dispatcher attached to this view.
MouseLockDispatcher* mouse_lock_dispatcher_;

Powered by Google App Engine
This is Rietveld 408576698