Migrate accessibility from RenderView to RenderFrame.

content/browser/accessibility/browser_accessibility_manager_win.cc

Index: content/browser/accessibility/browser_accessibility_manager_win.cc
diff --git a/content/browser/accessibility/browser_accessibility_manager_win.cc b/content/browser/accessibility/browser_accessibility_manager_win.cc
index 0bb3b60f948ccf4a7573c1afa27d8eda7777d9c2..05e2fd507e8c73f420260a6afdd5fb419948c956 100644
--- a/content/browser/accessibility/browser_accessibility_manager_win.cc
+++ b/content/browser/accessibility/browser_accessibility_manager_win.cc
@@ -55,7 +55,7 @@ BrowserAccessibilityManagerWin::~BrowserAccessibilityManagerWin() {
     tracked_scroll_object_ = NULL;
   }
   if (accessible_hwnd_)
-    accessible_hwnd_->OnManagerDeleted();
+    accessible_hwnd_->OnManagerDeleted(this);

[David Tseng, 2014/07/14 18:18:57]

|this| is deleted? Does it make sense to reame this method? Otherwise, |this|
seems to be an av if accessed.

[dmazzoni, 2014/07/15 07:55:03]

This is being called from within the destructor, why isn't that safe? It's
basically saying that the accessible hwnd should delete the manager if it's
equal to this, but not if it's already been passed a different manager. This is
necessary for tests to pass.

Here's a follow-up change with a better fix:
https://codereview.chromium.org/387353004/

 }
 
 // static
@@ -75,7 +75,11 @@ ui::AXTreeUpdate BrowserAccessibilityManagerWin::GetEmptyDocument() {
 
 void BrowserAccessibilityManagerWin::SetAccessibleHWND(
     LegacyRenderWidgetHostHWND* accessible_hwnd) {
+  if (accessible_hwnd_)
+    accessible_hwnd_->OnManagerDeleted(this);

[David Tseng, 2014/07/14 18:18:57]

This seems like an hidden side effect that might bite us in the future?

[dmazzoni, 2014/07/15 07:55:03]

Totally agreed - this is the minimal band-aid to make this work. Addressed by
this follow-up change: https://codereview.chromium.org/387353004/

+
   accessible_hwnd_ = accessible_hwnd;
+
   if (accessible_hwnd_) {
     accessible_hwnd_->set_browser_accessibility_manager(this);
     parent_hwnd_ = accessible_hwnd_->GetParent();