Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 273423003: Cleanup: remove temporary ifdefs for multi-sided patch in EmbeddedWorkerContextClient (Closed)

Created:
6 years, 7 months ago by kinuko
Modified:
6 years, 7 months ago
Reviewers:
horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, alecflett+watch_chromium.org
Visibility:
Public.

Description

Cleanup: remove temporary ifdefs for multi-sided patch in EmbeddedWorkerContextClient Now that blink side's landed and rolled we no longer need HAS_SERVICE_WORKER_CONTEXT_DESTROYED ifdefs BUG=366617 TEST=no functional changes Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269761

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M content/renderer/service_worker/embedded_worker_context_client.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kinuko
PTL
6 years, 7 months ago (2014-05-12 06:39:18 UTC) #1
horo
lgtm
6 years, 7 months ago (2014-05-12 07:04:07 UTC) #2
kinuko
The CQ bit was checked by kinuko@chromium.org
6 years, 7 months ago (2014-05-12 07:56:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/273423003/1
6 years, 7 months ago (2014-05-12 07:57:04 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-12 10:03:46 UTC) #5
Message was sent while issue was closed.
Change committed as 269761

Powered by Google App Engine
This is Rietveld 408576698