services/resource_coordinator/public/interfaces/memory/constants.mojom - Issue 2734193002: memory-infra: Finish moving to Mojo (2nd attempt)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: services/resource_coordinator/public/interfaces/memory/constants.mojom

Issue 2734193002: memory-infra: Finish moving to Mojo (2nd attempt) (Closed)

Patch Set: fixed CL Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module memory_instrumentation.mojom;

	6

	7 const uint64 kServiceTracingProcessId = 0xffffffffffffffff;
	ssid 2017/03/08 18:37:13 IIUC we should be having 2 constants here, browser IIUC we should be having 2 constants here, browser tracing id and invalid tracing id. chiniforooshan 2017/03/08 22:39:03 The invalid tracing id is defined in //base/trace_ Show quoted text On 2017/03/08 18:37:13, ssid wrote: > IIUC we should be having 2 constants here, browser tracing id and invalid > tracing id. The invalid tracing id is defined in //base/trace_event/memory_dump_manager and is used only there. I think we better leave it there since 1- we don't need it here, 2- //base cannot depend on //services. ssid 2017/03/09 00:23:15 Makes sense to keep it there. Thanks Show quoted text On 2017/03/08 22:39:03, chiniforooshan wrote: > On 2017/03/08 18:37:13, ssid wrote: > > IIUC we should be having 2 constants here, browser tracing id and invalid > > tracing id. > > The invalid tracing id is defined in //base/trace_event/memory_dump_manager and > is used only there. I think we better leave it there since 1- we don't need it > here, 2- //base cannot depend on //services. Makes sense to keep it there. Thanks
OLD	NEW