Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2734143002: Add test for cancel-future being awaited after an `await for`. (Closed)

Created:
3 years, 9 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 9 months ago
Reviewers:
Alan Knight, floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Move some status to language_kernel.status #

Total comments: 1

Patch Set 3 : Spell Cancelled with one l. Bloody Bowdlerization! #

Patch Set 4 : Merge #

Patch Set 5 : Update expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -34 lines) Patch
M tests/language/await_for_test.dart View 1 2 2 chunks +82 lines, -34 lines 0 comments Download
M tests/language/language.status View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M tests/language/language_kernel.status View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Lasse Reichstein Nielsen
3 years, 9 months ago (2017-03-07 10:59:33 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/2734143002/diff/20001/tests/language/await_for_test.dart File tests/language/await_for_test.dart (right): https://codereview.chromium.org/2734143002/diff/20001/tests/language/await_for_test.dart#newcode68 tests/language/await_for_test.dart:68: /// Creates a stream that yields integers forever, ...
3 years, 9 months ago (2017-03-07 12:31:18 UTC) #3
Lasse Reichstein Nielsen
Committed patchset #4 (id:60001) manually as 74a8351fb6ccb6789c9195a4b4905d853090d4e7 (presubmit successful).
3 years, 9 months ago (2017-03-07 17:05:42 UTC) #5
Alan Knight
This is causing failures on Dartium. Reverting
3 years, 9 months ago (2017-03-07 19:23:00 UTC) #7
Lasse Reichstein Nielsen
3 years, 9 months ago (2017-03-09 08:50:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
86d119e1ed354bb489237c815a358f04d1242158 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698