Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/browser/devtools/devtools_protocol.cc

Issue 2734123004: add a new set of commands to resize and position windows (Closed)
Patch Set: add methods to UI domain Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_protocol.cc
diff --git a/chrome/browser/devtools/devtools_protocol.cc b/chrome/browser/devtools/devtools_protocol.cc
index a22811053180c073bdcfd1f65072d176f448765c..f52d8425c6ae5a8678cc5fc7ef0e58cf75ee2c1c 100644
--- a/chrome/browser/devtools/devtools_protocol.cc
+++ b/chrome/browser/devtools/devtools_protocol.cc
@@ -19,9 +19,7 @@ const char kParamsParam[] = "params";
const char kResultParam[] = "result";
// JSON RPC 2.0 spec: http://www.jsonrpc.org/specification#error_object
-enum Error {
- kErrorInvalidParams = -32602
-};
+enum Error { kErrorInvalidParams = -32602, kErrorServerError = -32000 };
} // namespace
@@ -56,6 +54,18 @@ DevToolsProtocol::CreateInvalidParamsResponse(int command_id,
}
// static
+std::unique_ptr<base::DictionaryValue> DevToolsProtocol::CreateErrorResponse(
+ int command_id,
+ const std::string& error_message) {
+ std::unique_ptr<base::DictionaryValue> response(new base::DictionaryValue());
+ base::DictionaryValue* error_object = new base::DictionaryValue();
+ response->Set(kErrorParam, error_object);
+ error_object->SetInteger(kErrorCodeParam, kErrorServerError);
+ error_object->SetString(kErrorMessageParam, error_message);
+ return response;
+}
+
+// static
std::unique_ptr<base::DictionaryValue> DevToolsProtocol::CreateSuccessResponse(
int command_id,
std::unique_ptr<base::DictionaryValue> result) {

Powered by Google App Engine
This is Rietveld 408576698