Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3019)

Unified Diff: chrome/browser/ui/views/harmony/layout_delegate.h

Issue 2734113006: "Bootstrap" a toolkit-views Typography spec. (Closed)
Patch Set: Rebase (conflict in layout_delegate.h due to r457774) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/harmony/layout_delegate.h
diff --git a/chrome/browser/ui/views/harmony/layout_delegate.h b/chrome/browser/ui/views/harmony/layout_delegate.h
index 41780c42894f19c407976d6c4b6be72629dd6a90..d7d62520ead44d82bcd555f095d88ce40bf7b740 100644
--- a/chrome/browser/ui/views/harmony/layout_delegate.h
+++ b/chrome/browser/ui/views/harmony/layout_delegate.h
@@ -7,6 +7,10 @@
#include "ui/views/layout/grid_layout.h"
+namespace views {
+class TypographyProvider;
+}
+
class LayoutDelegate {
public:
enum class Metric {
@@ -84,6 +88,9 @@ class LayoutDelegate {
// Views for dialogs should not insert extra padding at their own edges.
virtual bool UseExtraDialogPadding() const;
+ // Returns whether to show the icon next to the title text on a dialog.
+ virtual bool ShouldShowWindowIcon() const;
+
// DEPRECATED. Returns whether Harmony mode is enabled.
//
// Instead of using this, create a generic solution that works for all UI
@@ -96,8 +103,9 @@ class LayoutDelegate {
// May return 0 if the dialog has no preferred width.
virtual int GetDialogPreferredWidth(DialogWidth width) const;
- // Returns whether to show the icon next to the title text on a dialog.
- virtual bool ShouldShowWindowIcon() const;
+ // Returns the class that maps views::style values (TextContext and TextStyle)
+ // to specific font properties (e.g. typeface, size, color, line spacing).
+ virtual const views::TypographyProvider& GetTypographyProvider() const;
private:
DISALLOW_COPY_AND_ASSIGN(LayoutDelegate);

Powered by Google App Engine
This is Rietveld 408576698