chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc - Issue 2734113006: "Bootstrap" a toolkit-views Typography spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc

Issue 2734113006: "Bootstrap" a toolkit-views Typography spec. (Closed)

Patch Set: respond to comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc ('k') | chrome/browser/ui/views/chrome_views_delegate.h » ('j') | chrome/browser/ui/views/content_setting_bubble_contents.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc

diff --git a/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc b/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc

index 06299c1d2a2bd8244467afcac02a0871e3d16e51..ac8275815abdb90c2c8ddae54bf2ba5678b5fbd3 100644

--- a/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc

+++ b/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc

@@ -51,14 +51,14 @@ class PasswordTextBox : public views::View {

SetLayoutManager(box_layout);

views::Label* suggestion_label = new views::Label(

- suggestion_text, font_list.DeriveWithWeight(gfx::Font::Weight::BOLD));

+ suggestion_text, {font_list.DeriveWithWeight(gfx::Font::Weight::BOLD)});

suggestion_label->SetHorizontalAlignment(gfx::ALIGN_LEFT);

suggestion_label->SetEnabledColor(

PasswordGenerationPopupView::kPasswordTextColor);

AddChildView(suggestion_label);

views::Label* password_label =

- new views::Label(generated_password, font_list);

+ new views::Label(generated_password, {font_list});

password_label->SetHorizontalAlignment(gfx::ALIGN_LEFT);

password_label->SetEnabledColor(

PasswordGenerationPopupView::kPasswordTextColor);