chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc - Issue 2734113006: "Bootstrap" a toolkit-views Typography spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc

Issue 2734113006: "Bootstrap" a toolkit-views Typography spec. (Closed)

Patch Set: Shred Typography class, follow-up on some other things. fix compile. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc

diff --git a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc

index 4a1ee58f508389df890a7b209b6a4dd1b1e56f21..630d0c8595b15f28c5f8bc90ed50d2770af5f810 100644

--- a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc

+++ b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc

@@ -27,7 +27,7 @@ constexpr int kSpaceBesideSeparator = 8;

IconLabelBubbleView::IconLabelBubbleView(const gfx::FontList& font_list,

bool elide_in_middle)

: image_(new views::ImageView()),

- label_(new views::Label(base::string16(), font_list)) {

+ label_(new views::Label(base::string16(), {font_list})) {

// Disable separate hit testing for |image_|. This prevents views treating

// |image_| as a separate mouse hover region from |this|.

image_->set_can_process_events_within_subtree(false);