Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1201)

Unified Diff: ios/chrome/browser/ui/settings/clear_browsing_data_egtest.mm

Issue 2733973002: Create shared matcher for navigation bar done button. (Closed)
Patch Set: remove sufficientlyVisible from shared matcher Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/settings/clear_browsing_data_egtest.mm
diff --git a/ios/chrome/browser/ui/settings/clear_browsing_data_egtest.mm b/ios/chrome/browser/ui/settings/clear_browsing_data_egtest.mm
index 6f07b47d0224f6ed160ba0a963008d6269a14572..b7e9421198563db2a40dd0afc87113d8de8b9da7 100644
--- a/ios/chrome/browser/ui/settings/clear_browsing_data_egtest.mm
+++ b/ios/chrome/browser/ui/settings/clear_browsing_data_egtest.mm
@@ -15,6 +15,7 @@
using chrome_test_util::ButtonWithAccessibilityLabel;
using chrome_test_util::ButtonWithAccessibilityLabelId;
+using chrome_test_util::NavigationBarDoneButton;
@interface ClearBrowsingDataSettingsTestCase : ChromeTestCase
@end
@@ -40,8 +41,7 @@ using chrome_test_util::ButtonWithAccessibilityLabelId;
}
- (void)exitSettingsMenu {
- [[EarlGrey selectElementWithMatcher:ButtonWithAccessibilityLabelId(
- IDS_IOS_NAVIGATION_BAR_DONE_BUTTON)]
+ [[EarlGrey selectElementWithMatcher:NavigationBarDoneButton()]
performAction:grey_tap()];
// Wait for UI components to finish loading.
[[GREYUIThreadExecutor sharedInstance] drainUntilIdle];
« no previous file with comments | « ios/chrome/browser/ui/settings/block_popups_egtest.mm ('k') | ios/chrome/browser/ui/settings/settings_egtest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698