Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: ios/chrome/browser/ui/keyboard_commands_egtest.mm

Issue 2733973002: Create shared matcher for navigation bar done button. (Closed)
Patch Set: remove sufficientlyVisible from shared matcher Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/keyboard_commands_egtest.mm
diff --git a/ios/chrome/browser/ui/keyboard_commands_egtest.mm b/ios/chrome/browser/ui/keyboard_commands_egtest.mm
index ae63e64d829c3e1a0499330520fdbd903ca96fe9..58616e3d59dee5295b281dbcc8e9fce23e05ed1c 100644
--- a/ios/chrome/browser/ui/keyboard_commands_egtest.mm
+++ b/ios/chrome/browser/ui/keyboard_commands_egtest.mm
@@ -28,6 +28,8 @@
#error "This file requires ARC support."
#endif
+using chrome_test_util::NavigationBarDoneButton;
+
const CGFloat kScrollDisplacement = 50.0;
// Test cases to verify that keyboard commands are and are not registered when
@@ -138,11 +140,7 @@ const CGFloat kScrollDisplacement = 50.0;
[self verifyNoKeyboardCommandsAreRegistered];
- // Close Settings
- id<GREYMatcher> settingsDoneButton =
- chrome_test_util::ButtonWithAccessibilityLabelId(
- IDS_IOS_NAVIGATION_BAR_DONE_BUTTON);
- [[EarlGrey selectElementWithMatcher:settingsDoneButton]
+ [[EarlGrey selectElementWithMatcher:NavigationBarDoneButton()]
performAction:grey_tap()];
}
« no previous file with comments | « ios/chrome/browser/ui/history/history_ui_egtest.mm ('k') | ios/chrome/browser/ui/settings/autofill_settings_egtest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698