ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm - Issue 2733973002: Create shared matcher for navigation bar done button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm

Issue 2733973002: Create shared matcher for navigation bar done button. (Closed)

Patch Set: remove sufficientlyVisible from shared matcher Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm

diff --git a/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm b/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm

index 5d1646aa06e90c5b2e246ff2539f510b3ceb0494..aeddb5975b5980e046edc5957636d9a6f6023c86 100644

--- a/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm

+++ b/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm

@@ -637,9 +637,7 @@ void SelectTabUsingUI(NSString* title) {

Wait(grey_accessibilityID(kPrivacyCollectionViewId),

@"Privacy settings view.");

- WaitAndTap(grey_accessibilityLabel(

- l10n_util::GetNSString(IDS_IOS_NAVIGATION_BAR_DONE_BUTTON)),

- @"Close settings");

+ WaitAndTap(chrome_test_util::NavigationBarDoneButton(), @"Close settings");

[[GREYUIThreadExecutor sharedInstance] drainUntilIdle];

[[EarlGrey selectElementWithMatcher:chrome_test_util::WebViewContainingText(

responses[slowURL])]

« no previous file with comments | « no previous file | ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm » ('j') | no next file with comments »