Create shared matcher for navigation bar done button.

ios/chrome/test/earl_grey/chrome_matchers.mm

Index: ios/chrome/test/earl_grey/chrome_matchers.mm
diff --git a/ios/chrome/test/earl_grey/chrome_matchers.mm b/ios/chrome/test/earl_grey/chrome_matchers.mm
index bf7833c9c31efeb93ed9c42f37f6a7a95fcc638e..86bc5136cc450c55b383ecc4f1e9b517c633902f 100644
--- a/ios/chrome/test/earl_grey/chrome_matchers.mm
+++ b/ios/chrome/test/earl_grey/chrome_matchers.mm
@@ -231,4 +231,10 @@ id<GREYMatcher> OpenLinkInNewTabMenuItem() {
   return ButtonWithAccessibilityLabelId(IDS_IOS_CONTENT_CONTEXT_OPENLINKNEWTAB);
 }
 
+id<GREYMatcher> NavigationBarDoneButton() {
+  return grey_allOf(
+      ButtonWithAccessibilityLabelId(IDS_IOS_NAVIGATION_BAR_DONE_BUTTON),
+      grey_sufficientlyVisible(), nil);

[Eugene But (OOO till 7-30), 2017/03/07 02:56:41]

I just noticed that some matchers have |grey_sufficientlyVisible| and some
don't. I to be fair it's quite unexpected to me that these methods have
|grey_sufficientlyVisible| check. Do we even need this check? If so, should we
use a different function name (f.e. SufficientlyVisibleNavigationBarDoneButton)?

[baxley, 2017/03/07 15:28:33]

There was one at least one test that needed it, so I just put it in here. I
think it's better to not have it, so I removed it and created a local variable
matcher for the test that needs it (testClearBrowsingHistory in
history_ui_egtest).

I'm running this through the try bots to make sure nothing else needs it.

[Eugene But (OOO till 7-30), 2017/03/07 16:33:31]

Thanks! Could you please file a bug to fix other matchers as well.

+}
+
 }  // namespace chrome_test_util