[Payments] Return a basic card response

components/payments/core/payment_address.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/payments/core/payment_address.h"
+
+#include "base/strings/utf_string_conversions.h"
+#include "base/values.h"
+
+namespace web {
+
+namespace {
+
+// These are defined as part of the spec at:
+// https://w3c.github.io/browser-payment-api/.

[please use gerrit instead, 2017/03/08 14:46:09]

https://w3c.github.io/browser-payment-api/#paymentaddress-interface

[Mathieu, 2017/03/08 18:04:25]

Done.

+static const char kAddressAddressLine[] = "addressLine";
+static const char kAddressCity[] = "city";
+static const char kAddressCountry[] = "country";
+static const char kAddressDependentLocality[] = "dependentLocality";
+static const char kAddressLanguageCode[] = "languageCode";
+static const char kAddressOrganization[] = "organization";
+static const char kAddressPhone[] = "phone";
+static const char kAddressPostalCode[] = "postalCode";
+static const char kAddressRecipient[] = "recipient";
+static const char kAddressRegion[] = "region";
+static const char kAddressSortingCode[] = "sortingCode";
+
+}  // namespace
+
+PaymentAddress::PaymentAddress() {}
+PaymentAddress::PaymentAddress(const PaymentAddress& other) = default;
+PaymentAddress::~PaymentAddress() = default;
+
+bool PaymentAddress::operator==(const PaymentAddress& other) const {
+  return this->country == other.country &&
+         this->address_line == other.address_line &&
+         this->region == other.region && this->city == other.city &&
+         this->dependent_locality == other.dependent_locality &&
+         this->postal_code == other.postal_code &&
+         this->sorting_code == other.sorting_code &&
+         this->language_code == other.language_code &&
+         this->organization == other.organization &&
+         this->recipient == other.recipient && this->care_of == other.care_of &&
+         this->phone == other.phone;
+}
+
+bool PaymentAddress::operator!=(const PaymentAddress& other) const {
+  return !(*this == other);
+}
+
+std::unique_ptr<base::DictionaryValue> PaymentAddress::ToDictionaryValue()
+    const {
+  std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue());
+
+  if (!this->country.empty())
+    result->SetString(kAddressCountry, this->country);
+
+  if (!this->address_line.empty()) {
+    std::unique_ptr<base::ListValue> address_line(new base::ListValue);

[please use gerrit instead, 2017/03/08 14:46:09]

base::MakeUnique<base::ListValue>();

[Mathieu, 2017/03/08 18:04:25]

Done.

+    for (base::string16 address_line_string : this->address_line) {

[please use gerrit instead, 2017/03/08 14:46:09]

Use "const base::string16&" instead of "base::string16" to avoid copies.

[Mathieu, 2017/03/08 18:04:25]

Done.

+      if (!address_line_string.empty())
+        address_line->AppendString(address_line_string);
+    }
+    result->Set(kAddressAddressLine, std::move(address_line));
+  }
+
+  if (!this->region.empty())
+    result->SetString(kAddressRegion, this->region);
+  if (!this->city.empty())
+    result->SetString(kAddressCity, this->city);
+  if (!this->dependent_locality.empty())
+    result->SetString(kAddressDependentLocality, this->dependent_locality);
+  if (!this->postal_code.empty())
+    result->SetString(kAddressPostalCode, this->postal_code);
+  if (!this->sorting_code.empty())
+    result->SetString(kAddressSortingCode, this->sorting_code);
+  if (!this->language_code.empty())
+    result->SetString(kAddressLanguageCode, this->language_code);
+  if (!this->organization.empty())
+    result->SetString(kAddressOrganization, this->organization);
+  if (!this->recipient.empty())
+    result->SetString(kAddressRecipient, this->recipient);
+  if (!this->phone.empty())
+    result->SetString(kAddressPhone, this->phone);
+
+  return result;
+}
+
+}  // namespace web