Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

Issue 2733933003: Move CompositeEditCommand::deleteSelection() to TypingCommand::deleteSelectionIfRange() (Closed)
Patch Set: 2017-03-07T13:11:49 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp b/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp
index e47b8b27d0ba607435d0a760bdd461d957cb98f9..aa47768f20334b22511d758ee9a077483a02ef9b 100644
--- a/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp
@@ -813,8 +813,7 @@ void TypingCommand::deleteKeyPressed(TextGranularity granularity,
if (frame->editor().behavior().shouldUndoOfDeleteSelectText() &&
m_openedByBackwardDelete)
setStartingSelection(selectionAfterUndo);
- CompositeEditCommand::deleteSelection(selectionToDelete, editingState,
- m_smartDelete);
+ deleteSelectionIfRange(selectionToDelete, editingState, m_smartDelete);
if (editingState->isAborted())
return;
setSmartDelete(false);
@@ -941,8 +940,7 @@ void TypingCommand::forwardDeleteKeyPressed(TextGranularity granularity,
// Make undo select what was deleted on Mac alone
if (frame->editor().behavior().shouldUndoOfDeleteSelectText())
setStartingSelection(selectionAfterUndo);
- CompositeEditCommand::deleteSelection(selectionToDelete, editingState,
- m_smartDelete);
+ deleteSelectionIfRange(selectionToDelete, editingState, m_smartDelete);
if (editingState->isAborted())
return;
setSmartDelete(false);

Powered by Google App Engine
This is Rietveld 408576698