Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Issue 2733913002: Fix for parsing 'const X()' with Fasta. (Closed)

Created:
3 years, 9 months ago by scheglov
Modified:
3 years, 9 months ago
Reviewers:
Paul Berry, ahe
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M pkg/analyzer/test/generated/parser_fasta_test.dart View 2 chunks +0 lines, -12 lines 0 comments Download
M pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
scheglov
3 years, 9 months ago (2017-03-06 18:34:42 UTC) #1
Paul Berry
lgtm
3 years, 9 months ago (2017-03-06 18:37:23 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 2a60cbf9deb61758468f5b8c0038c200fa529e86 (presubmit successful).
3 years, 9 months ago (2017-03-06 19:00:40 UTC) #4
ahe
3 years, 9 months ago (2017-03-07 15:22:30 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698