Issue 27339: Merge the latest version of PR_ParseTimeString....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27339: Merge the latest version of PR_ParseTimeString.... (Closed)

Created:
11 years, 9 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
eroman

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Merge the latest version of PR_ParseTimeString. This requires us to bring in two more functions: PR_NormalizeTime and PR_GMTParameters. R=eroman BUG=4387 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10738

Total comments: 2

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+456 lines, -148 lines)			Patch
	M	base/third_party/nspr/prtime.h	View		3 chunks	+88 lines, -40 lines	0 comments	Download
	M	base/third_party/nspr/prtime.cc	View		16 chunks	+368 lines, -108 lines	0 comments	Download

Total messages: 2 (0 generated)

wtc

It is difficult to review a merge CL like this. I will email you a ...

11 years, 9 months ago (2009-03-02 19:07:39 UTC) #1

lgtm.

i reviewed primarily the supplemental diff.