content/browser/media/session/media_session_impl_service_routing_unittest.cc - Issue 2733843003: Fix a crash when receiving PAUSE action but no service is routed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/session/media_session_impl_service_routing_unittest.cc

Issue 2733843003: Fix a crash when receiving PAUSE action but no service is routed (Closed)

Patch Set: added unit tests Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/media/session/media_session_impl_service_routing_unittest.cc

diff --git a/content/browser/media/session/media_session_impl_service_routing_unittest.cc b/content/browser/media/session/media_session_impl_service_routing_unittest.cc

index ff969be22f82f8a2087d93a39661b1d92d4cf39f..48d1c2edf07484d11f75afd3c524a3f37fb3c1d3 100644

--- a/content/browser/media/session/media_session_impl_service_routing_unittest.cc

+++ b/content/browser/media/session/media_session_impl_service_routing_unittest.cc

@@ -402,4 +402,15 @@ TEST_F(MediaSessionImplServiceRoutingTest,

run_loop.Run();

}

+TEST_F(MediaSessionImplServiceRoutingTest,

+ TestReceivingPauseActionWhenNoServiceRouted) {

+ CreateServiceForFrame(main_frame_);

+ CreateServiceForFrame(sub_frame_);

+ ASSERT_EQ(nullptr, ComputeServiceForRouting());

+ MediaSessionImpl::Get(contents())

+ ->DidReceiveAction(blink::mojom::MediaSessionAction::PAUSE);

mlamouri (slow - plz ping) 2017/03/06 19:19:07 Add a comment that it should not crash.

} // namespace content

« no previous file with comments | « content/browser/media/session/media_session_impl.cc ('k') | no next file » | no next file with comments »