Chromium Code Reviews| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 35bf3ee00b5c96f35104ccaf8a92476c6e6b2fea..a4cb8afc145c8575e7db12d87e15abcc913e3096 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -68716,12 +68716,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <histogram name="SubresourceFilter.PageLoad.RedirectChainLength" units="urls"> |
| <owner>melandory@chromium.org</owner> |
| + <suffix name="SocialEngineeringAdsInterstitial"/> |
| + <suffix name="PhishingInterstitial"/> |
|
jwd
2017/03/15 14:10:38
You don't need the suffix tags in the histogram ta
melandory
2017/03/15 14:21:33
Sorry, I already fixed when this CL was second in
|
| <summary>Total length of the server redirects during the navigation.</summary> |
| </histogram> |
| <histogram name="SubresourceFilter.PageLoad.RedirectChainMatchPattern" |
| enum="SubresourceFilterMatchPattern"> |
| <owner>melandory@chromium.org</owner> |
| + <suffix name="SocialEngineeringAdsInterstitial"/> |
| + <suffix name="PhishingInterstitial"/> |
| <summary> |
| For each main frame navigation, records a pattern that indicates which URLs |
| in the redirect chain matched Safe Browsing blacklists, and which did not. |
| @@ -122125,6 +122129,14 @@ from previous Chrome versions. |
| <affected-histogram name="WebRTC.Stun.SuccessPercent.UnknownNAT"/> |
| </histogram_suffixes> |
| +<histogram_suffixes name="SubresourceFilterOnlyExperiment" separator="."> |
| + <suffix name="SocialEngineeringAdsInterstitial"/> |
|
jwd
2017/03/15 14:10:38
Can you add a label to these suffixes, to make the
melandory
2017/03/15 14:21:33
Done.
|
| + <suffix name="PhishingInterstitial"/> |
| + <affected-histogram name="SubresourceFilter.PageLoad.RedirectChainLength"/> |
| + <affected-histogram |
| + name="SubresourceFilter.PageLoad.RedirectChainMatchPattern"/> |
| +</histogram_suffixes> |
| + |
| <histogram_suffixes name="SyncModelType" separator="."> |
| <suffix name="APP" label="APP"/> |
| <suffix name="APP_LIST" label="APP_LIST"/> |