tools/metrics/histograms/histograms.xml - Issue 2733833002: Change logic for recording redirect pattern histograms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2733833002: Change logic for recording redirect pattern histograms. (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 35bf3ee00b5c96f35104ccaf8a92476c6e6b2fea..a4cb8afc145c8575e7db12d87e15abcc913e3096 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -68716,12 +68716,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<owner>melandory@chromium.org</owner>

+ <suffix name="SocialEngineeringAdsInterstitial"/>

+ <suffix name="PhishingInterstitial"/>

jwd 2017/03/15 14:10:38 You don't need the suffix tags in the histogram ta

melandory 2017/03/15 14:21:33 Sorry, I already fixed when this CL was second in

<summary>Total length of the server redirects during the navigation.</summary>

</histogram>

<histogram name="SubresourceFilter.PageLoad.RedirectChainMatchPattern"

enum="SubresourceFilterMatchPattern">

<owner>melandory@chromium.org</owner>

+ <suffix name="SocialEngineeringAdsInterstitial"/>

+ <suffix name="PhishingInterstitial"/>

For each main frame navigation, records a pattern that indicates which URLs

in the redirect chain matched Safe Browsing blacklists, and which did not.

@@ -122125,6 +122129,14 @@ from previous Chrome versions.

<affected-histogram name="WebRTC.Stun.SuccessPercent.UnknownNAT"/>

</histogram_suffixes>

+<histogram_suffixes name="SubresourceFilterOnlyExperiment" separator=".">

+ <suffix name="SocialEngineeringAdsInterstitial"/>

jwd 2017/03/15 14:10:38 Can you add a label to these suffixes, to make the

melandory 2017/03/15 14:21:33 Done.

+ <suffix name="PhishingInterstitial"/>

+ <affected-histogram name="SubresourceFilter.PageLoad.RedirectChainLength"/>

+ <affected-histogram

+ name="SubresourceFilter.PageLoad.RedirectChainMatchPattern"/>

+</histogram_suffixes>

<histogram_suffixes name="SyncModelType" separator=".">

« no previous file with comments | « components/subresource_filter/core/common/activation_list.cc ('k') | no next file » | no next file with comments »