src/base/macros.h - Issue 273383003: v8::TryCatch now works correctly with ASAN's UseAfterReturn mode enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/base/macros.h

Issue 273383003: v8::TryCatch now works correctly with ASAN's UseAfterReturn mode enabled. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressing review notes Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/base/macros.h

diff --git a/src/base/macros.h b/src/base/macros.h

index b99f01b230c52db6c11e90a49c608919ae6ccfab..fa522fb94531c26f4eb7e95b0b3ed910ea43ad93 100644

--- a/src/base/macros.h

+++ b/src/base/macros.h

@@ -54,15 +54,17 @@

#define MUST_USE_RESULT V8_WARN_UNUSED_RESULT

-// Define DISABLE_ASAN macros.

+// Define V8_USE_ADDRESS_SANITIZER macros.

#if defined(__has_feature)

#if __has_feature(address_sanitizer)

-#define DISABLE_ASAN __attribute__((no_sanitize_address))

+#define V8_USE_ADDRESS_SANITIZER 1

#endif

-#ifndef DISABLE_ASAN

+// Define DISABLE_ASAN macros.

+#ifdef V8_USE_ADDRESS_SANITIZER

+#define DISABLE_ASAN __attribute__((no_sanitize_address))

+#else

#define DISABLE_ASAN

#endif

« no previous file with comments | « src/api.cc ('k') | src/isolate.cc » ('j') | no next file with comments »