Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.cpp

Issue 2733793002: Get rid of FrameSelection::setSelection() taking VisibleSelection and SetSelectionOptions (Closed)
Patch Set: 2017-03-06T16:47:26 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/FrameSelection.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/FrameSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.cpp b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
index 04b7419d2570c87b5a381677851a5c971ad4f03c..248d99647bb07219eac01aae09842fb5abc9f49a 100644
--- a/third_party/WebKit/Source/core/editing/FrameSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
@@ -320,11 +320,6 @@ void FrameSelection::setSelection(const VisibleSelection& newSelection,
options, align, granularity);
}
-void FrameSelection::setSelection(const VisibleSelection& newSelection,
- SetSelectionOptions options) {
- setSelection(newSelection.asSelection(), options);
-}
-
void FrameSelection::nodeChildrenWillBeRemoved(ContainerNode& container) {
if (!container.inActiveDocument())
return;
@@ -398,7 +393,7 @@ bool FrameSelection::modify(EAlteration alter,
const SetSelectionOptions options =
CloseTyping | ClearTypingStyle | userTriggered;
- setSelection(selectionModifier.selection(), options);
+ setSelection(selectionModifier.selection().asSelection(), options);
if (granularity == LineGranularity || granularity == ParagraphGranularity)
m_xPosForVerticalArrowNavigation =
« no previous file with comments | « third_party/WebKit/Source/core/editing/FrameSelection.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698