Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2733773004: Add check for missing visual rect updates and fix failures (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 536 matching lines...) Expand 10 before | Expand all | Expand 10 after
547 547
548 frameRectsChanged(); 548 frameRectsChanged();
549 549
550 updateParentScrollableAreaSet(); 550 updateParentScrollableAreaSet();
551 551
552 if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled() && 552 if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled() &&
553 !RuntimeEnabledFeatures::rootLayerScrollingEnabled()) { 553 !RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
554 // The overflow clip property depends on the frame size and the pre 554 // The overflow clip property depends on the frame size and the pre
555 // translation property depends on the frame location. 555 // translation property depends on the frame location.
556 setNeedsPaintPropertyUpdate(); 556 setNeedsPaintPropertyUpdate();
557 if (auto layoutViewItem = this->layoutViewItem())
558 layoutViewItem.setMayNeedPaintInvalidation();
557 } 559 }
558 560
559 if (frameSizeChanged) { 561 if (frameSizeChanged) {
560 viewportSizeChanged(newRect.width() != oldRect.width(), 562 viewportSizeChanged(newRect.width() != oldRect.width(),
561 newRect.height() != oldRect.height()); 563 newRect.height() != oldRect.height());
562 564
563 if (m_frame->isMainFrame()) 565 if (m_frame->isMainFrame())
564 m_frame->host()->visualViewport().mainFrameDidChangeSize(); 566 m_frame->host()->visualViewport().mainFrameDidChangeSize();
565 567
566 frame().loader().restoreScrollPositionAndViewState(); 568 frame().loader().restoreScrollPositionAndViewState();
(...skipping 4683 matching lines...) Expand 10 before | Expand all | Expand 10 after
5250 void FrameView::setAnimationHost( 5252 void FrameView::setAnimationHost(
5251 std::unique_ptr<CompositorAnimationHost> host) { 5253 std::unique_ptr<CompositorAnimationHost> host) {
5252 m_animationHost = std::move(host); 5254 m_animationHost = std::move(host);
5253 } 5255 }
5254 5256
5255 LayoutUnit FrameView::caretWidth() const { 5257 LayoutUnit FrameView::caretWidth() const {
5256 return LayoutUnit(getHostWindow()->windowToViewportScalar(1)); 5258 return LayoutUnit(getHostWindow()->windowToViewportScalar(1));
5257 } 5259 }
5258 5260
5259 } // namespace blink 5261 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698