third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp - Issue 2733763003: Reimplement [PutForwards] per spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp

Issue 2733763003: Reimplement [PutForwards] per spec (Closed)

Patch Set: avoid using v8::Maybe Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp

index b1dd4e905543aa4f24bcfa5cb9d63afba786dbd3..7b3de4e6034d7d4950c02414d26f0f1d2975948c 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp

@@ -79,6 +79,8 @@ static void uLongLongAttributeAttributeSetter(v8::Local<v8::Value> v8Value, cons

ALLOW_UNUSED_LOCAL(isolate);

v8::Local<v8::Object> holder = info.Holder();

+ ALLOW_UNUSED_LOCAL(holder);

TestTypedefs* impl = V8TestTypedefs::toImpl(holder);

ExceptionState exceptionState(isolate, ExceptionState::kSetterContext, "TestTypedefs", "uLongLongAttribute");

@@ -107,6 +109,8 @@ static void domStringOrDoubleOrNullAttributeAttributeSetter(v8::Local<v8::Value>

ALLOW_UNUSED_LOCAL(isolate);

v8::Local<v8::Object> holder = info.Holder();

+ ALLOW_UNUSED_LOCAL(holder);

TestTypedefs* impl = V8TestTypedefs::toImpl(holder);

ExceptionState exceptionState(isolate, ExceptionState::kSetterContext, "TestTypedefs", "domStringOrDoubleOrNullAttribute");