third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.cpp - Issue 2733763003: Reimplement [PutForwards] per spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.cpp

Issue 2733763003: Reimplement [PutForwards] per spec (Closed)

Patch Set: avoid using v8::Maybe Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.cpp

index 670fb29b8b053363b827b26a80d5d4204c629f12..30738ffe12202b0bb6fbce148d9086770b5670de 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.cpp

@@ -67,6 +67,8 @@ static void hrefAttributeSetter(v8::Local<v8::Value> v8Value, const v8::Function

ALLOW_UNUSED_LOCAL(isolate);

v8::Local<v8::Object> holder = info.Holder();

+ ALLOW_UNUSED_LOCAL(holder);

TestNode* impl = V8TestNode::toImpl(holder);

// Prepare the value to be set.

@@ -90,6 +92,8 @@ static void hrefThrowsAttributeSetter(v8::Local<v8::Value> v8Value, const v8::Fu

ALLOW_UNUSED_LOCAL(isolate);

v8::Local<v8::Object> holder = info.Holder();

+ ALLOW_UNUSED_LOCAL(holder);

TestNode* impl = V8TestNode::toImpl(holder);

ExceptionState exceptionState(isolate, ExceptionState::kSetterContext, "TestNode", "hrefThrows");

@@ -115,6 +119,8 @@ static void hrefCallWithAttributeSetter(v8::Local<v8::Value> v8Value, const v8::

ALLOW_UNUSED_LOCAL(isolate);

v8::Local<v8::Object> holder = info.Holder();

+ ALLOW_UNUSED_LOCAL(holder);

TestNode* impl = V8TestNode::toImpl(holder);

// Prepare the value to be set.

@@ -140,6 +146,8 @@ static void hrefByteStringAttributeSetter(v8::Local<v8::Value> v8Value, const v8

ALLOW_UNUSED_LOCAL(isolate);

v8::Local<v8::Object> holder = info.Holder();

+ ALLOW_UNUSED_LOCAL(holder);

TestNode* impl = V8TestNode::toImpl(holder);

ExceptionState exceptionState(isolate, ExceptionState::kSetterContext, "TestNode", "hrefByteString");