third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp - Issue 2733763003: Reimplement [PutForwards] per spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp

Issue 2733763003: Reimplement [PutForwards] per spec (Closed)

Patch Set: avoid using v8::Maybe Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp

index 01e4c43f1279e8284dc38f40d7717a65b2ecf4ae..b70e3cf644f7a47ea5413391f93b6459f0cf4705 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp

@@ -77,6 +77,8 @@ static void longAttributeAttributeSetter(v8::Local<v8::Value> v8Value, const v8:

ALLOW_UNUSED_LOCAL(isolate);

v8::Local<v8::Object> holder = info.Holder();

+ ALLOW_UNUSED_LOCAL(holder);

TestInterfaceCheckSecurity* impl = V8TestInterfaceCheckSecurity::toImpl(holder);

ExceptionState exceptionState(isolate, ExceptionState::kSetterContext, "TestInterfaceCheckSecurity", "longAttribute");

@@ -102,6 +104,8 @@ static void doNotCheckSecurityLongAttributeAttributeSetter(v8::Local<v8::Value>

ALLOW_UNUSED_LOCAL(isolate);

v8::Local<v8::Object> holder = info.Holder();

+ ALLOW_UNUSED_LOCAL(holder);

TestInterfaceCheckSecurity* impl = V8TestInterfaceCheckSecurity::toImpl(holder);

ExceptionState exceptionState(isolate, ExceptionState::kSetterContext, "TestInterfaceCheckSecurity", "doNotCheckSecurityLongAttribute");

@@ -135,6 +139,8 @@ static void doNotCheckSecurityOnSetterLongAttributeAttributeSetter(v8::Local<v8:

ALLOW_UNUSED_LOCAL(isolate);

v8::Local<v8::Object> holder = info.Holder();

+ ALLOW_UNUSED_LOCAL(holder);

TestInterfaceCheckSecurity* impl = V8TestInterfaceCheckSecurity::toImpl(holder);

ExceptionState exceptionState(isolate, ExceptionState::kSetterContext, "TestInterfaceCheckSecurity", "doNotCheckSecurityOnSetterLongAttribute");