third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp - Issue 2733763003: Reimplement [PutForwards] per spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp

Issue 2733763003: Reimplement [PutForwards] per spec (Closed)

Patch Set: avoid using v8::Maybe Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp

index 7d188607c13d97eedf7a136c09a4acb29f0e59b4..a614a2823d7f012e016b0242ca82fdda9a5ce3ef 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp

@@ -70,6 +70,8 @@ static void voidCallbackFunctionAttributeAttributeSetter(v8::Local<v8::Value> v8

ALLOW_UNUSED_LOCAL(isolate);

v8::Local<v8::Object> holder = info.Holder();

+ ALLOW_UNUSED_LOCAL(holder);

TestCallbackFunctions* impl = V8TestCallbackFunctions::toImpl(holder);

// Prepare the value to be set.

@@ -91,6 +93,8 @@ static void anyCallbackFunctionOptionalAnyArgAttributeAttributeSetter(v8::Local<

ALLOW_UNUSED_LOCAL(isolate);

v8::Local<v8::Object> holder = info.Holder();

+ ALLOW_UNUSED_LOCAL(holder);

TestCallbackFunctions* impl = V8TestCallbackFunctions::toImpl(holder);

// Prepare the value to be set.