Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: third_party/WebKit/public/platform/WebLayerStickyPositionConstraint.h

Issue 2733633002: Handle nested position:sticky elements correctly (compositor) (Closed)
Patch Set: Revert float changes to unittests too Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/trees/property_tree.cc ('K') | « third_party/WebKit/public/platform/WebLayer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/WebLayerStickyPositionConstraint.h
diff --git a/third_party/WebKit/public/platform/WebLayerStickyPositionConstraint.h b/third_party/WebKit/public/platform/WebLayerStickyPositionConstraint.h
index 296496d76f24a22d2545fa38c5d5c6555e31f2ef..ad3b85ccd8b7081c4dcb1e505a63570f495f746b 100644
--- a/third_party/WebKit/public/platform/WebLayerStickyPositionConstraint.h
+++ b/third_party/WebKit/public/platform/WebLayerStickyPositionConstraint.h
@@ -26,6 +26,7 @@
#ifndef WebLayerStickyPositionConstraint_h
#define WebLayerStickyPositionConstraint_h
+#include "public/platform/WebLayer.h"
#include "public/platform/WebPoint.h"
#include "public/platform/WebRect.h"
@@ -62,6 +63,11 @@ struct WebLayerStickyPositionConstraint {
// element should not be shifted beyond.
WebRect scrollContainerRelativeContainingBlockRect;
+ // The nearest ancestor sticky layers that affect the sticky box constraint
+ // rect and the containing block constraint rect respectively.
+ int nearestLayerShiftingStickyBox;
+ int nearestLayerShiftingContainingBlock;
+
WebLayerStickyPositionConstraint()
: isSticky(false),
isAnchoredLeft(false),
@@ -71,7 +77,9 @@ struct WebLayerStickyPositionConstraint {
leftOffset(0.f),
rightOffset(0.f),
topOffset(0.f),
- bottomOffset(0.f) {}
+ bottomOffset(0.f),
+ nearestLayerShiftingStickyBox(WebLayer::kInvalidLayerId),
+ nearestLayerShiftingContainingBlock(WebLayer::kInvalidLayerId) {}
};
} // namespace blink
« cc/trees/property_tree.cc ('K') | « third_party/WebKit/public/platform/WebLayer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698